[GitHub] [druid] suneet-s commented on a change in pull request #11662: Fix moving average extension loading in middle manager and overlord

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #11662:
URL: https://github.com/apache/druid/pull/11662#discussion_r703510910



##########
File path: extensions-contrib/moving-average-query/src/main/java/org/apache/druid/query/movingaverage/MovingAverageQueryModule.java
##########
@@ -58,4 +68,25 @@ public void configure(Binder binder)
                                                  )));
   }
 
+  @Provides
+  @LazySingleton
+  @Named("movingAverage")
+  public QuerySegmentWalker createQueryWalker(@Self Set<NodeRole> nodeRoles, Injector injector)
+  {
+    if (!nodeRoles.contains(NodeRole.BROKER)) {

Review comment:
       Have you tried using a moving average query through the router? Does it still work?
   
   When I tried the extension a little while ago, I had to enable it on the router as well to get the query to run successfully.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org