You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "orionlibs (via GitHub)" <gi...@apache.org> on 2023/07/17 22:09:47 UTC

[GitHub] [commons-lang] orionlibs commented on a diff in pull request #1071: LANG-1695: NumberUtils::isParseable does not recognise numbers ending in dot

orionlibs commented on code in PR #1071:
URL: https://github.com/apache/commons-lang/pull/1071#discussion_r1265949881


##########
src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java:
##########
@@ -918,7 +918,8 @@ public void testIsParsable() {
         assertFalse(NumberUtils.isParsable("pendro"));
         assertFalse(NumberUtils.isParsable("64, 2"));
         assertFalse(NumberUtils.isParsable("64.2.2"));
-        assertFalse(NumberUtils.isParsable("64."));
+        assertTrue(NumberUtils.isParsable("64."));

Review Comment:
   @elharo sorry. My understanding of the ticket is that 64. is valid



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org