You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Maja Kabiljo (JIRA)" <ji...@apache.org> on 2012/11/06 07:40:12 UTC
[jira] [Created] (GIRAPH-412) Checkstyle error from Giraph-403
Maja Kabiljo created GIRAPH-412:
-----------------------------------
Summary: Checkstyle error from Giraph-403
Key: GIRAPH-412
URL: https://issues.apache.org/jira/browse/GIRAPH-412
Project: Giraph
Issue Type: Bug
Reporter: Maja Kabiljo
Attachments: GIRAPH-412.patch
I didn't try to run mvn verify before committing GIRAPH-403. It complained about:
"The double-checked locking idiom is broken and should be avoided."
The reason why double-locking is bad doesn't apply here - it applies to cases where we actually use the value of a variable which we are creating in this way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Created] (GIRAPH-412) Checkstyle error from Giraph-403
Posted by Eli Reisman <ap...@gmail.com>.
I was under the impression that the double-check locking in Java has been
phased out because the value visible in the first (unlocked) check as its
seen from the CPU executing the current thread might be stale in the cache
and not updated so you might get false negatives/positives if you check
without the lock, and might never make it past the unlocked check when you
should. I believe it still works if the var in the unlocked check is
volatile but in that case the cache is getting flushed all the time with
each check anyway, and might not present a gain compared to just locking
and checking. Is this wrong? I had noticed these checks in the patch too.
On Mon, Nov 5, 2012 at 10:40 PM, Maja Kabiljo (JIRA) <ji...@apache.org>wrote:
> Maja Kabiljo created GIRAPH-412:
> -----------------------------------
>
> Summary: Checkstyle error from Giraph-403
> Key: GIRAPH-412
> URL: https://issues.apache.org/jira/browse/GIRAPH-412
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Attachments: GIRAPH-412.patch
>
> I didn't try to run mvn verify before committing GIRAPH-403. It complained
> about:
> "The double-checked locking idiom is broken and should be avoided."
> The reason why double-locking is bad doesn't apply here - it applies to
> cases where we actually use the value of a variable which we are creating
> in this way.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
[jira] [Resolved] (GIRAPH-412) Checkstyle error from Giraph-403
Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maja Kabiljo resolved GIRAPH-412.
---------------------------------
Resolution: Fixed
> Checkstyle error from Giraph-403
> --------------------------------
>
> Key: GIRAPH-412
> URL: https://issues.apache.org/jira/browse/GIRAPH-412
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-412.patch
>
>
> I didn't try to run mvn verify before committing GIRAPH-403. It complained about:
> "The double-checked locking idiom is broken and should be avoided."
> The reason why double-locking is bad doesn't apply here - it applies to cases where we actually use the value of a variable which we are creating in this way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GIRAPH-412) Checkstyle error from Giraph-403
Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maja Kabiljo reassigned GIRAPH-412:
-----------------------------------
Assignee: Maja Kabiljo
> Checkstyle error from Giraph-403
> --------------------------------
>
> Key: GIRAPH-412
> URL: https://issues.apache.org/jira/browse/GIRAPH-412
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-412.patch
>
>
> I didn't try to run mvn verify before committing GIRAPH-403. It complained about:
> "The double-checked locking idiom is broken and should be avoided."
> The reason why double-locking is bad doesn't apply here - it applies to cases where we actually use the value of a variable which we are creating in this way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-412) Checkstyle error from Giraph-403
Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maja Kabiljo updated GIRAPH-412:
--------------------------------
Attachment: GIRAPH-412.patch
> Checkstyle error from Giraph-403
> --------------------------------
>
> Key: GIRAPH-412
> URL: https://issues.apache.org/jira/browse/GIRAPH-412
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Attachments: GIRAPH-412.patch
>
>
> I didn't try to run mvn verify before committing GIRAPH-403. It complained about:
> "The double-checked locking idiom is broken and should be avoided."
> The reason why double-locking is bad doesn't apply here - it applies to cases where we actually use the value of a variable which we are creating in this way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-412) Checkstyle error from Giraph-403
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491256#comment-13491256 ]
Avery Ching commented on GIRAPH-412:
------------------------------------
+1
> Checkstyle error from Giraph-403
> --------------------------------
>
> Key: GIRAPH-412
> URL: https://issues.apache.org/jira/browse/GIRAPH-412
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-412.patch
>
>
> I didn't try to run mvn verify before committing GIRAPH-403. It complained about:
> "The double-checked locking idiom is broken and should be avoided."
> The reason why double-locking is bad doesn't apply here - it applies to cases where we actually use the value of a variable which we are creating in this way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-412) Checkstyle error from Giraph-403
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491265#comment-13491265 ]
Hudson commented on GIRAPH-412:
-------------------------------
Integrated in Giraph-trunk-Commit #274 (See [https://builds.apache.org/job/Giraph-trunk-Commit/274/])
GIRAPH-412: Checkstyle error from Giraph-403 (Revision 1406058)
Result = SUCCESS
maja : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406058
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/GraphMapper.java
> Checkstyle error from Giraph-403
> --------------------------------
>
> Key: GIRAPH-412
> URL: https://issues.apache.org/jira/browse/GIRAPH-412
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-412.patch
>
>
> I didn't try to run mvn verify before committing GIRAPH-403. It complained about:
> "The double-checked locking idiom is broken and should be avoided."
> The reason why double-locking is bad doesn't apply here - it applies to cases where we actually use the value of a variable which we are creating in this way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira