You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/04/20 08:29:33 UTC

[kudu-CR] [log] A log in master catalog manager may not correct.

Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18428


Change subject: [log] A log in master catalog_manager may not correct.
......................................................................

[log] A log in master catalog_manager may not correct.

Fix a variable table_rows_limit, it used by a log in master,
it maybe not correct before.

The variable table_rows_limit, when table_disk_size_limit and
table_row_count_limit all setted, and has reached the
table_disk_size_limit, variable table_rows_limit is -1(default) before.

Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
---
M src/kudu/master/catalog_manager.cc
1 file changed, 5 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>

[kudu-CR] [log] A log in master catalog manager may not correct.

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18428

to look at the new patch set (#2).

Change subject: [log] A log in master catalog_manager may not correct.
......................................................................

[log] A log in master catalog_manager may not correct.

Fix a variable table_rows_limit, it used by a log in master,
it maybe not correct before.

The variable table_rows_limit, when table_disk_size_limit and
table_row_count_limit all setted, and has reached the
table_disk_size_limit, variable table_rows_limit is -1(default) before.

Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
---
M src/kudu/master/catalog_manager.cc
1 file changed, 5 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master log] Correction for the value of `table rows limit`

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18428 )

Change subject: [master_log] Correction for the value of `table_rows_limit`
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18428/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18428/6//COMMIT_MSG@7
PS6, Line 7: [master_log] Correction for the value of `table_rows_limit`
> nit:How about "[master_log] Correction for the value of `table_rows_limit`"
Done


http://gerrit.cloudera.org:8080/#/c/18428/6/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18428/6/src/kudu/master/catalog_manager.cc@3649
PS6, Line 3649: FLAGS_table_write_limit_ratio
> nit: How about adding this flag to the log? Seems it's not always 1, just i
good.  DONE



-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sat, 30 Apr 2022 07:28:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master log] Correction for the value of `table rows limit`

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18428

to look at the new patch set (#8).

Change subject: [master_log] Correction for the value of `table_rows_limit`
......................................................................

[master_log] Correction for the value of `table_rows_limit`

Fix a variable table_rows_limit, it used by a log in master,
it maybe not correct before.

The variable table_rows_limit, when table_disk_size_limit and
table_row_count_limit all setted, and has reached the
table_disk_size_limit, variable table_rows_limit is -1(default) before.

Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
---
M src/kudu/master/catalog_manager.cc
1 file changed, 9 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 8
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [master log] Correction for the value of `table rows limit`

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has removed a vote on this change.

Change subject: [master_log] Correction for the value of `table_rows_limit`
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [master log] Correction for the value of `table rows limit`

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18428 )

Change subject: [master_log] Correction for the value of `table_rows_limit`
......................................................................

[master_log] Correction for the value of `table_rows_limit`

Fix a variable table_rows_limit, it used by a log in master,
it maybe not correct before.

The variable table_rows_limit, when table_disk_size_limit and
table_row_count_limit all setted, and has reached the
table_disk_size_limit, variable table_rows_limit is -1(default) before.

Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Reviewed-on: http://gerrit.cloudera.org:8080/18428
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/master/catalog_manager.cc
1 file changed, 9 insertions(+), 13 deletions(-)

Approvals:
  Yifan Zhang: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 10
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [master log] Correction for the value of `table rows limit`

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18428

to look at the new patch set (#7).

Change subject: [master_log] Correction for the value of `table_rows_limit`
......................................................................

[master_log] Correction for the value of `table_rows_limit`

Fix a variable table_rows_limit, it used by a log in master,
it maybe not correct before.

The variable table_rows_limit, when table_disk_size_limit and
table_row_count_limit all setted, and has reached the
table_disk_size_limit, variable table_rows_limit is -1(default) before.

Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
---
M src/kudu/master/catalog_manager.cc
1 file changed, 9 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [log] Make a variable table rows limit correct, which used by catalog manager.cc

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18428 )

Change subject: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18428/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18428/6//COMMIT_MSG@7
PS6, Line 7: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc
nit:How about "[master_log] Correction for the value of `table_rows_limit`"


http://gerrit.cloudera.org:8080/#/c/18428/6/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18428/6/src/kudu/master/catalog_manager.cc@3649
PS6, Line 3649: FLAGS_table_write_limit_ratio
nit: How about adding this flag to the log? Seems it's not always 1, just in case we need this info to find out why write ops are rejected.



-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 29 Apr 2022 11:54:42 +0000
Gerrit-HasComments: Yes

[kudu-CR] [log] Make a variable table rows limit correct, which used by catalog manager.cc

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18428

to look at the new patch set (#5).

Change subject: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc
......................................................................

[log] Make a variable table_rows_limit correct, which used by catalog_manager.cc

Fix a variable table_rows_limit, it used by a log in master,
it maybe not correct before.

The variable table_rows_limit, when table_disk_size_limit and
table_row_count_limit all setted, and has reached the
table_disk_size_limit, variable table_rows_limit is -1(default) before.

Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
---
M src/kudu/master/catalog_manager.cc
1 file changed, 5 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master log] Correction for the value of `table rows limit`

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18428 )

Change subject: [master_log] Correction for the value of `table_rows_limit`
......................................................................


Patch Set 9: Verified+1 Code-Review+2

Unrelated test failures in CatalogManagerConfigurations/MasterStressTest.Test/1.


-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sun, 01 May 2022 03:31:06 +0000
Gerrit-HasComments: No

[kudu-CR] [log] Make a variable table rows limit correct, which used by catalog manager.cc

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18428

to look at the new patch set (#3).

Change subject: [log] Make a variable table_rows_limit correct, which used by catalog_manager.cc
......................................................................

[log] Make a variable table_rows_limit correct, which used by catalog_manager.cc

Fix a variable table_rows_limit, it used by a log in master,
it maybe not correct before.

The variable table_rows_limit, when table_disk_size_limit and
table_row_count_limit all setted, and has reached the
table_disk_size_limit, variable table_rows_limit is -1(default) before.

Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
---
M src/kudu/master/catalog_manager.cc
1 file changed, 5 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master log] Correction for the value of `table rows limit`

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18428

to look at the new patch set (#9).

Change subject: [master_log] Correction for the value of `table_rows_limit`
......................................................................

[master_log] Correction for the value of `table_rows_limit`

Fix a variable table_rows_limit, it used by a log in master,
it maybe not correct before.

The variable table_rows_limit, when table_disk_size_limit and
table_row_count_limit all setted, and has reached the
table_disk_size_limit, variable table_rows_limit is -1(default) before.

Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
---
M src/kudu/master/catalog_manager.cc
1 file changed, 9 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/18428/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18428
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79365f2eda90ec49e99565f897c27ca43773fafa
Gerrit-Change-Number: 18428
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>