You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/19 19:57:52 UTC
[GitHub] [airflow] potiuk opened a new pull request #21689: Convert our internal tools to use rich_click
potiuk opened a new pull request #21689:
URL: https://github.com/apache/airflow/pull/21689
Rich_click provides out-of-the-box beautifying of the click command
line tools to provide 'rich' help output.
This PR changes our internal tools (including the new Breeze2
in-progress effort to use rich click to make our help nicer.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21689: Convert our internal tools to use rich_click
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21689:
URL: https://github.com/apache/airflow/pull/21689#issuecomment-1046092585
cc: @Bowrna @edithturn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21689: Convert our internal tools to use rich_click
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21689:
URL: https://github.com/apache/airflow/pull/21689#issuecomment-1046092878
BTW. Should we convert Airflow to use click ? Seems more and more worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21689: Convert our internal tools to use rich_click
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21689:
URL: https://github.com/apache/airflow/pull/21689#issuecomment-1046092675
Some screenshots :)
<img width="1242" alt="Screenshot 2022-02-19 at 20 53 44" src="https://user-images.githubusercontent.com/595491/154817014-4c13c9e1-ae0c-4cda-8442-37e3fc82428d.png">
<img width="1240" alt="Screenshot 2022-02-19 at 20 53 14" src="https://user-images.githubusercontent.com/595491/154817018-69fd8ec4-4d27-40fb-8c89-636d07bc3f64.png">
<img width="1251" alt="Screenshot 2022-02-19 at 20 43 16" src="https://user-images.githubusercontent.com/595491/154817020-7b6437b7-7901-4657-9c60-27b3f827841e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21689: Convert our internal tools to use rich_click
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21689:
URL: https://github.com/apache/airflow/pull/21689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21689: Convert our internal tools to use rich_click
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21689:
URL: https://github.com/apache/airflow/pull/21689#issuecomment-1046096056
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org