You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/12 01:37:23 UTC
[GitHub] [incubator-nuttx] v01d opened a new pull request #1765: Fix: ensure archive files do not carry object files from prior builds
v01d opened a new pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765
## Summary
In some cases, when NuttX configuration changes and this makes the
object list used to build one of the .a libraries change as well,
since the command used to build it is "ar crs" and this simply appends
the list of object files, the library could still include object
files from prior builds. This commit modifies the ARCHIVE macro to
erase the .a file if it already exists.
Since in some cases this behavior was actually expected (object
files from a subdirectory were appended to a library created one
level above) I added a ARCHIVE_ADD which works as ARCHIVE did.
This change should greatly improve behavior of building after
configuration changes.
## Impact
Build system
## Testing
Build problem was fixed, the archive was recreated and linker errors due to "multiple references" disappeared.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691774163
@Ouss4 looks good, please go ahead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691703378
I removed references to flock in documentation as `apps` no longer uses (as @xiaoxiang781216 suggested)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691415904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691970275
Thanks @xiaoxiang781216, sorry for being late.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691415904
Hmm this one is odd I am not sure either. @xiaoxiang781216 do you have any thoughts on what might cause this behaviour.
The test script issues.
```
function makefunc {
if ! ${MAKE} ${MAKE_FLAGS} "${EXTRA_FLAGS}" ${JOPTION} $@ 1>/dev/null; then
fail=1
fi
```
MacOS:
```
/github/workspace/sources/nuttx/staging/libsched.a(nx_bringup.o): In function `nx_bringup':
nx_bringup.c:(.text+0x8): undefined reference to `hello_main'
nx_bringup.c:(.text+0xa): undefined reference to `hello_main'
make[1]: *** [Makefile:122: nuttx] Error 1
make: *** [tools/Makefile.unix:401: nuttx] Error 2
```
Linux:
```
/github/workspace/sources/nuttx/staging/libsched.a(nx_bringup.o): In function `nx_bringup':
nx_bringup.c:(.text+0x8): undefined reference to `nsh_main'
nx_bringup.c:(.text+0xa): undefined reference to `nsh_main'
make[1]: *** [Makefile:122: nuttx] Error 1
make: *** [tools/Makefile.unix:401: nuttx] Error 2
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691386347
Hey, there's a strange problem with CI: this fails since it requires a change in `apps`, however the failure is only reported by GH for macOS where actually all Linux jobs fail as well (look in the details). I don't understand how this could happen. Maybe an OS difference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691415904
Hmm this one is odd I am not sure either. @xiaoxiang781216 do you have any thoughts on what might cause this behaviour.
The test script issues.
```
function makefunc {
if ! ${MAKE} ${MAKE_FLAGS} "${EXTRA_FLAGS}" ${JOPTION} $@ 1>/dev/null; then
fail=1
fi
```
MacOS:
```
/github/workspace/sources/nuttx/staging/libsched.a(nx_bringup.o): In function `nx_bringup':
nx_bringup.c:(.text+0x8): undefined reference to `hello_main'
nx_bringup.c:(.text+0xa): undefined reference to `hello_main'
make[1]: *** [Makefile:122: nuttx] Error 1
make: *** [tools/Makefile.unix:401: nuttx] Error 2
```
Linux:
```
/github/workspace/sources/nuttx/staging/libsched.a(nx_bringup.o): In function `nx_bringup':
nx_bringup.c:(.text+0x8): undefined reference to `nsh_main'
nx_bringup.c:(.text+0xa): undefined reference to `nsh_main'
make[1]: *** [Makefile:122: nuttx] Error 1
make: *** [tools/Makefile.unix:401: nuttx] Error 2
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691886769
I will merge both PR now, let's watch whether the new build script can handle the next couple PR correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691415904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691386347
Hey, there's a strange problem with CI: this fails since it requires a change in `apps`, however the failure is only reported by GH for macOS where actually all Linux jobs fail as well (look in the details). I don't understand how this could happen. Maybe an OS difference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691386347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1765: Fix: ensure archive files do not carry object files from prior builds
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1765:
URL: https://github.com/apache/incubator-nuttx/pull/1765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org