[GitHub] [maven-jenkins-lib] slawekjaranowski commented on a change in pull request #3: default run on Jenkins should be faster (only 2 last series of maven releases, site with only one jdk)

[GitBox <gi...@apache.org>]

slawekjaranowski commented on a change in pull request #3:
URL: https://github.com/apache/maven-jenkins-lib/pull/3#discussion_r815290285



##########
File path: vars/asfMavenTlpPlgnBuild.groovy
##########
@@ -119,18 +123,25 @@ def doCreateTask( os, jdk, maven, tasks, first, plan, taskContext )
     echo "Skipping ${os}-jdk${jdk} as unsupported by Jenkins Environment"
     return;
   }
+  def recordReporting = false	
   def cmd = [
     'mvn', '-V',
     '-P+run-its',
-    '-Dmaven.test.failure.ignore=true',
     '-Dfindbugs.failOnError=false',
     '-e',
+    taskContext.extraCmd  
   ]
   if (!first) {
     cmd += '-Dfindbugs.skip=true'
 //  } else { // Requires authorization on SonarQube first
 //    cmd += 'sonar:sonar'
+  }	  
+  if (Integer.parseInt(jdk) >= 11 && !taskContext['ciReportingRunned']) {
+    cmd += "-Pci-reporting -Perrorprone" 

Review comment:
       `ci-reporting` , `errorprone` are is some new profiles, I didn't see those before

##########
File path: vars/asfMavenTlpPlgnBuild.groovy
##########
@@ -213,6 +224,15 @@ def doCreateTask( os, jdk, maven, tasks, first, plan, taskContext )
                 }
               }
             }
+            if(recordReporting) {
+              recordIssues id: "${os}-jdk${jdk}", name: "Static Analysis", aggregatingResults: true, enabledForFailure: true, tools: [mavenConsole(), java(), checkStyle(), spotBugs(), pmdParser(), errorProne()]    
+              jacoco inclusionPattern: '**/org/apache/maven/**/*.class',
+                     exclusionPattern: '',
+                     execPattern: '**/target/jacoco.exec',

Review comment:
       `jacoco-it.exec` should also be included 

##########
File path: vars/asfMavenTlpPlgnBuild.groovy
##########
@@ -38,18 +38,21 @@ def call(Map params = [:]) {
 	// minimum, LTS, current and next ea
     def jdks = params.containsKey('jdks') ? params.jdks : params.containsKey('jdk') ? params.jdk : ['8','11','17']
     def jdkMin = jdks[0];
-    def mavens = params.containsKey('maven') ? params.maven : ['3.2.x','3.3.x','3.5.x','3.6.x']
+    def mavens = params.containsKey('maven') ? params.maven : ['3.6.x','3.8.x']
     // def failFast = params.containsKey('failFast') ? params.failFast : true
     // Just temporarily
     def failFast = false;
-    def siteJdks = params.containsKey('siteJdk') ? params.siteJdk : ['8','17']
-    def siteMvn = params.containsKey('siteMvn') ? params.siteMvn : '3.6.x'
+    def siteJdks = params.containsKey('siteJdk') ? params.siteJdk : ['8']

Review comment:
       should be at minimum 11, there are difference for javadoc




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org