You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/31 16:45:59 UTC

[GitHub] [kafka] cmccabe commented on pull request #12294: KAFKA-13990: KRaft controller should return right features in ApiVersionResponse

cmccabe commented on PR #12294:
URL: https://github.com/apache/kafka/pull/12294#issuecomment-1233178487

   Thanks for finding this, @dengziming . It is a great find and definitely a 3.3 blocker.
   
   Two comments:
   
   * ZK brokers should not expose metadata.version (they should have a supported range from 0-0, aka no supported range)
   
   * I want to get rid of all the "use an empty feature set" factory functions in `ApiVersionsResponse.java`. I made this comment before on a different review, and we left them in, and now we had this major bug. It's time to get rid of all of them. If people want an empty feature set, they can specify that explicitly.
   
   Thanks again for the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org