You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2017/05/29 21:06:10 UTC
Wrong home for log4j-server stuff
I find that the Git repo logging-log4j-tools is the wrong home for
log4-server. This is not a tool. It's a runtime component. I do not see why
it cannot live in main repo.
I use tools at development time. YMMV.
Gary
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Wrong home for log4j-server stuff
Posted by Remko Popma <re...@gmail.com>.
I like log4j-samples better than log4j-server for the same reasons that Mikael and Ralph mentioned. True, it has already been released, but the module breakup gives us a chance to clarify our intentions.
(Shameless plug) Every java main() method deserves http://picocli.info
> On May 31, 2017, at 4:44, Gary Gregory <ga...@gmail.com> wrote:
>
>> On Tue, May 30, 2017 at 12:37 PM, Mikael Ståldal <mi...@apache.org> wrote:
>>
>> Sounds good. I like to declare it as sample, since it is not really
>> production ready on the level of quality and security I would like us to
>> maintain the core of Log4j. If we want to declare it as production ready, I
>> think we have some work to do to improve it.
>>
>> We recently had to make a security patch for a deserialization
>> vulnerability in the code that is now part of log4j-server. And we just got
>> a bug report: https://issues.apache.org/jira/browse/LOG4J2-1922
>>
>> If we declare it as sample, it would be less urgent to make such patches,
>> and to fix such bugs.
>
>
> Except that the code is already released, so that argument is moot :-(
>
> Gary
>
>
>>
>>
>>> On 2017-05-30 19:37, Ralph Goers wrote:
>>>
>>> I plan on moving the log4j-samples module to a separate repo anyway. I
>>> see no reason why the server can’t go into that repo.
>>>
>>>> On May 30, 2017, at 10:33 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>
>>>> Making a new repo isn't a big deal. Once we figure out a nice way to
>>>> build
>>>> two separate repos, that can easily extend to N separate repos, right? ;)
>>>>
>>>> On 30 May 2017 at 11:26, Mikael Ståldal <mi...@apache.org> wrote:
>>>>
>>>> I put it in log4j-tools since it Ralph didn't wanted it in the main repo,
>>>>> and there was not other existing repo which fitted better.
>>>>>
>>>>> I don't mind moving it to the main repo, or to some other new repo (if
>>>>> we
>>>>> find it worth the effort to create and setup yet another repo, I am
>>>>> skeptic). I would object reintegrating it into the log4j-core module
>>>>> though.
>>>>>
>>>>>
>>>>>
>>>>> On 2017-05-29 23:32, Ralph Goers wrote:
>>>>>
>>>>> I agree it doesn’t belong in the tools repo. It really belongs in a
>>>>>> log4j-examples or log4j-samples as that is all it was meant to be.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>>
>>>>>>> I find that the Git repo logging-log4j-tools is the wrong home for
>>>>>>> log4-server. This is not a tool. It's a runtime component. I do not
>>>>>>> see
>>>>>>> why
>>>>>>> it cannot live in main repo.
>>>>>>>
>>>>>>> I use tools at development time. YMMV.
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>> --
>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?
>>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link
>>>>>>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>>>>>
>>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>>> am2&o=1&a=1617290459>
>>>>>>> JUnit in Action, Second Edition
>>>>>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?
>>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link
>>>>>>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a
>>>>>>> 24de418%22>
>>>>>>>
>>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>>> am2&o=1&a=1935182021>
>>>>>>> Spring Batch in Action
>>>>>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?
>>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link
>>>>>>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli
>>>>>>> nk_id%7D%7D%22%3ESpring+Batch+in+Action>
>>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>>> am2&o=1&a=1935182951>
>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>> Home: http://garygregory.com/
>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Matt Sicker <bo...@gmail.com>
>>>>
>>>
>>>
>>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: Wrong home for log4j-server stuff
Posted by Gary Gregory <ga...@gmail.com>.
On Tue, May 30, 2017 at 12:37 PM, Mikael Ståldal <mi...@apache.org> wrote:
> Sounds good. I like to declare it as sample, since it is not really
> production ready on the level of quality and security I would like us to
> maintain the core of Log4j. If we want to declare it as production ready, I
> think we have some work to do to improve it.
>
> We recently had to make a security patch for a deserialization
> vulnerability in the code that is now part of log4j-server. And we just got
> a bug report: https://issues.apache.org/jira/browse/LOG4J2-1922
>
> If we declare it as sample, it would be less urgent to make such patches,
> and to fix such bugs.
Except that the code is already released, so that argument is moot :-(
Gary
>
>
> On 2017-05-30 19:37, Ralph Goers wrote:
>
>> I plan on moving the log4j-samples module to a separate repo anyway. I
>> see no reason why the server can’t go into that repo.
>>
>> On May 30, 2017, at 10:33 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>> Making a new repo isn't a big deal. Once we figure out a nice way to
>>> build
>>> two separate repos, that can easily extend to N separate repos, right? ;)
>>>
>>> On 30 May 2017 at 11:26, Mikael Ståldal <mi...@apache.org> wrote:
>>>
>>> I put it in log4j-tools since it Ralph didn't wanted it in the main repo,
>>>> and there was not other existing repo which fitted better.
>>>>
>>>> I don't mind moving it to the main repo, or to some other new repo (if
>>>> we
>>>> find it worth the effort to create and setup yet another repo, I am
>>>> skeptic). I would object reintegrating it into the log4j-core module
>>>> though.
>>>>
>>>>
>>>>
>>>> On 2017-05-29 23:32, Ralph Goers wrote:
>>>>
>>>> I agree it doesn’t belong in the tools repo. It really belongs in a
>>>>> log4j-examples or log4j-samples as that is all it was meant to be.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>> I find that the Git repo logging-log4j-tools is the wrong home for
>>>>>> log4-server. This is not a tool. It's a runtime component. I do not
>>>>>> see
>>>>>> why
>>>>>> it cannot live in main repo.
>>>>>>
>>>>>> I use tools at development time. YMMV.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?
>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link
>>>>>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>>>>
>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>> am2&o=1&a=1617290459>
>>>>>> JUnit in Action, Second Edition
>>>>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?
>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link
>>>>>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a
>>>>>> 24de418%22>
>>>>>>
>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>> am2&o=1&a=1935182021>
>>>>>> Spring Batch in Action
>>>>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?
>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link
>>>>>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli
>>>>>> nk_id%7D%7D%22%3ESpring+Batch+in+Action>
>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>> am2&o=1&a=1935182951>
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>>
>>
>>
>>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Wrong home for log4j-server stuff
Posted by Mikael Ståldal <mi...@apache.org>.
Sounds good. I like to declare it as sample, since it is not really
production ready on the level of quality and security I would like us to
maintain the core of Log4j. If we want to declare it as production
ready, I think we have some work to do to improve it.
We recently had to make a security patch for a deserialization
vulnerability in the code that is now part of log4j-server. And we just
got a bug report: https://issues.apache.org/jira/browse/LOG4J2-1922
If we declare it as sample, it would be less urgent to make such
patches, and to fix such bugs.
On 2017-05-30 19:37, Ralph Goers wrote:
> I plan on moving the log4j-samples module to a separate repo anyway. I see no reason why the server can’t go into that repo.
>
>> On May 30, 2017, at 10:33 AM, Matt Sicker <bo...@gmail.com> wrote:
>>
>> Making a new repo isn't a big deal. Once we figure out a nice way to build
>> two separate repos, that can easily extend to N separate repos, right? ;)
>>
>> On 30 May 2017 at 11:26, Mikael Ståldal <mi...@apache.org> wrote:
>>
>>> I put it in log4j-tools since it Ralph didn't wanted it in the main repo,
>>> and there was not other existing repo which fitted better.
>>>
>>> I don't mind moving it to the main repo, or to some other new repo (if we
>>> find it worth the effort to create and setup yet another repo, I am
>>> skeptic). I would object reintegrating it into the log4j-core module though.
>>>
>>>
>>>
>>> On 2017-05-29 23:32, Ralph Goers wrote:
>>>
>>>> I agree it doesn’t belong in the tools repo. It really belongs in a
>>>> log4j-examples or log4j-samples as that is all it was meant to be.
>>>>
>>>> Ralph
>>>>
>>>> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>
>>>>> I find that the Git repo logging-log4j-tools is the wrong home for
>>>>> log4-server. This is not a tool. It's a runtime component. I do not see
>>>>> why
>>>>> it cannot live in main repo.
>>>>>
>>>>> I use tools at development time. YMMV.
>>>>>
>>>>> Gary
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?
>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link
>>>>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>>>
>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>> am2&o=1&a=1617290459>
>>>>> JUnit in Action, Second Edition
>>>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?
>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link
>>>>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>>>>
>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>> am2&o=1&a=1935182021>
>>>>> Spring Batch in Action
>>>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?
>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link
>>>>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli
>>>>> nk_id%7D%7D%22%3ESpring+Batch+in+Action>
>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>> am2&o=1&a=1935182951>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>
>
Re: Wrong home for log4j-server stuff
Posted by Ralph Goers <ra...@dslextreme.com>.
The point is that the server isn’t really very useful by itself. The intent was for you to copy it and add whatever logic you want to it. That is what makes it a sample.
Ralph
> On May 30, 2017, at 12:10 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> On Tue, May 30, 2017 at 10:37 AM, Ralph Goers <ralph.goers@dslextreme.com <ma...@dslextreme.com>>
> wrote:
>
>> I plan on moving the log4j-samples module to a separate repo anyway. I see
>> no reason why the server can’t go into that repo.
>>
>>> On May 30, 2017, at 10:33 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>> Making a new repo isn't a big deal. Once we figure out a nice way to
>> build
>>> two separate repos, that can easily extend to N separate repos, right? ;)
>>>
>>> On 30 May 2017 at 11:26, Mikael Ståldal <mi...@apache.org> wrote:
>>>
>>>> I put it in log4j-tools since it Ralph didn't wanted it in the main
>> repo,
>>>> and there was not other existing repo which fitted better.
>>>>
>>>> I don't mind moving it to the main repo, or to some other new repo (if
>> we
>>>> find it worth the effort to create and setup yet another repo, I am
>>>> skeptic). I would object reintegrating it into the log4j-core module
>> though.
>>>>
>>>>
>>>>
>>>> On 2017-05-29 23:32, Ralph Goers wrote:
>>>>
>>>>> I agree it doesn’t belong in the tools repo. It really belongs in a
>>>>> log4j-examples or log4j-samples as that is all it was meant to be.
>>
>
> That's not quite right IMO. In Log4j 1 we have XMLSocketReceiver in the
> "extras" jar. We actually use XMLSocketReceiver at work and when that
> product is eventually ported to Log4j 2, it would be weird to deliver a
> log4j-samples jar as part of our runtime. As it is now, log4j-server is
> 'normal' but the fact that it comes from the samples repo is a bit odd but
> not as bad as delivering a log4j-samples. What is the solution? I still
> like have a the module log4j-server in the main repo.
>
> Gary
>
>
>>>>>
>>>>> Ralph
>>>>>
>>>>> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>>>>>
>>>>>> I find that the Git repo logging-log4j-tools is the wrong home for
>>>>>> log4-server. This is not a tool. It's a runtime component. I do not
>> see
>>>>>> why
>>>>>> it cannot live in main repo.
>>>>>>
>>>>>> I use tools at development time. YMMV.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?
>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link
>>>>>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>>>>
>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>> am2&o=1&a=1617290459>
>>>>>> JUnit in Action, Second Edition
>>>>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?
>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link
>>>>>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4
>> 18%22>
>>>>>>
>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>> am2&o=1&a=1935182021>
>>>>>> Spring Batch in Action
>>>>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?
>>>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link
>>>>>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli
>>>>>> nk_id%7D%7D%22%3ESpring+Batch+in+Action>
>>>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>>>> am2&o=1&a=1935182951>
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8 <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459 <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22 <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021 <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951 <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
Re: Wrong home for log4j-server stuff
Posted by Gary Gregory <ga...@gmail.com>.
On Tue, May 30, 2017 at 10:37 AM, Ralph Goers <ra...@dslextreme.com>
wrote:
> I plan on moving the log4j-samples module to a separate repo anyway. I see
> no reason why the server can’t go into that repo.
>
> > On May 30, 2017, at 10:33 AM, Matt Sicker <bo...@gmail.com> wrote:
> >
> > Making a new repo isn't a big deal. Once we figure out a nice way to
> build
> > two separate repos, that can easily extend to N separate repos, right? ;)
> >
> > On 30 May 2017 at 11:26, Mikael Ståldal <mi...@apache.org> wrote:
> >
> >> I put it in log4j-tools since it Ralph didn't wanted it in the main
> repo,
> >> and there was not other existing repo which fitted better.
> >>
> >> I don't mind moving it to the main repo, or to some other new repo (if
> we
> >> find it worth the effort to create and setup yet another repo, I am
> >> skeptic). I would object reintegrating it into the log4j-core module
> though.
> >>
> >>
> >>
> >> On 2017-05-29 23:32, Ralph Goers wrote:
> >>
> >>> I agree it doesn’t belong in the tools repo. It really belongs in a
> >>> log4j-examples or log4j-samples as that is all it was meant to be.
>
That's not quite right IMO. In Log4j 1 we have XMLSocketReceiver in the
"extras" jar. We actually use XMLSocketReceiver at work and when that
product is eventually ported to Log4j 2, it would be weird to deliver a
log4j-samples jar as part of our runtime. As it is now, log4j-server is
'normal' but the fact that it comes from the samples repo is a bit odd but
not as bad as delivering a log4j-samples. What is the solution? I still
like have a the module log4j-server in the main repo.
Gary
> >>>
> >>> Ralph
> >>>
> >>> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com>
> wrote:
> >>>>
> >>>> I find that the Git repo logging-log4j-tools is the wrong home for
> >>>> log4-server. This is not a tool. It's a runtime component. I do not
> see
> >>>> why
> >>>> it cannot live in main repo.
> >>>>
> >>>> I use tools at development time. YMMV.
> >>>>
> >>>> Gary
> >>>>
> >>>> --
> >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >>>> Java Persistence with Hibernate, Second Edition
> >>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?
> >>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link
> >>>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
> >>>>
> >>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> >>>> am2&o=1&a=1617290459>
> >>>> JUnit in Action, Second Edition
> >>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?
> >>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link
> >>>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de4
> 18%22>
> >>>>
> >>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> >>>> am2&o=1&a=1935182021>
> >>>> Spring Batch in Action
> >>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?
> >>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link
> >>>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli
> >>>> nk_id%7D%7D%22%3ESpring+Batch+in+Action>
> >>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
> >>>> am2&o=1&a=1935182951>
> >>>> Blog: http://garygregory.wordpress.com
> >>>> Home: http://garygregory.com/
> >>>> Tweet! http://twitter.com/GaryGregory
> >>>>
> >>>
> >>>
> >>>
> >>
> >
> >
> > --
> > Matt Sicker <bo...@gmail.com>
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Wrong home for log4j-server stuff
Posted by Ralph Goers <ra...@dslextreme.com>.
I plan on moving the log4j-samples module to a separate repo anyway. I see no reason why the server can’t go into that repo.
> On May 30, 2017, at 10:33 AM, Matt Sicker <bo...@gmail.com> wrote:
>
> Making a new repo isn't a big deal. Once we figure out a nice way to build
> two separate repos, that can easily extend to N separate repos, right? ;)
>
> On 30 May 2017 at 11:26, Mikael Ståldal <mi...@apache.org> wrote:
>
>> I put it in log4j-tools since it Ralph didn't wanted it in the main repo,
>> and there was not other existing repo which fitted better.
>>
>> I don't mind moving it to the main repo, or to some other new repo (if we
>> find it worth the effort to create and setup yet another repo, I am
>> skeptic). I would object reintegrating it into the log4j-core module though.
>>
>>
>>
>> On 2017-05-29 23:32, Ralph Goers wrote:
>>
>>> I agree it doesn’t belong in the tools repo. It really belongs in a
>>> log4j-examples or log4j-samples as that is all it was meant to be.
>>>
>>> Ralph
>>>
>>> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>> I find that the Git repo logging-log4j-tools is the wrong home for
>>>> log4-server. This is not a tool. It's a runtime component. I do not see
>>>> why
>>>> it cannot live in main repo.
>>>>
>>>> I use tools at development time. YMMV.
>>>>
>>>> Gary
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?
>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link
>>>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>>
>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>> am2&o=1&a=1617290459>
>>>> JUnit in Action, Second Edition
>>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?
>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link
>>>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>>>
>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>> am2&o=1&a=1935182021>
>>>> Spring Batch in Action
>>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?
>>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link
>>>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli
>>>> nk_id%7D%7D%22%3ESpring+Batch+in+Action>
>>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>>> am2&o=1&a=1935182951>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>>
>>>
>>
>
>
> --
> Matt Sicker <bo...@gmail.com>
Re: Wrong home for log4j-server stuff
Posted by Matt Sicker <bo...@gmail.com>.
Making a new repo isn't a big deal. Once we figure out a nice way to build
two separate repos, that can easily extend to N separate repos, right? ;)
On 30 May 2017 at 11:26, Mikael Ståldal <mi...@apache.org> wrote:
> I put it in log4j-tools since it Ralph didn't wanted it in the main repo,
> and there was not other existing repo which fitted better.
>
> I don't mind moving it to the main repo, or to some other new repo (if we
> find it worth the effort to create and setup yet another repo, I am
> skeptic). I would object reintegrating it into the log4j-core module though.
>
>
>
> On 2017-05-29 23:32, Ralph Goers wrote:
>
>> I agree it doesn’t belong in the tools repo. It really belongs in a
>> log4j-examples or log4j-samples as that is all it was meant to be.
>>
>> Ralph
>>
>> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>> I find that the Git repo logging-log4j-tools is the wrong home for
>>> log4-server. This is not a tool. It's a runtime component. I do not see
>>> why
>>> it cannot live in main repo.
>>>
>>> I use tools at development time. YMMV.
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?
>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&link
>>> Code=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>
>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>> am2&o=1&a=1617290459>
>>> JUnit in Action, Second Edition
>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?
>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&link
>>> Code=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>>
>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>> am2&o=1&a=1935182021>
>>> Spring Batch in Action
>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?
>>> ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&link
>>> Code=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Bli
>>> nk_id%7D%7D%22%3ESpring+Batch+in+Action>
>>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=
>>> am2&o=1&a=1935182951>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>
--
Matt Sicker <bo...@gmail.com>
Re: Wrong home for log4j-server stuff
Posted by Mikael Ståldal <mi...@apache.org>.
I put it in log4j-tools since it Ralph didn't wanted it in the main
repo, and there was not other existing repo which fitted better.
I don't mind moving it to the main repo, or to some other new repo (if
we find it worth the effort to create and setup yet another repo, I am
skeptic). I would object reintegrating it into the log4j-core module though.
On 2017-05-29 23:32, Ralph Goers wrote:
> I agree it doesn’t belong in the tools repo. It really belongs in a log4j-examples or log4j-samples as that is all it was meant to be.
>
> Ralph
>
>> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> I find that the Git repo logging-log4j-tools is the wrong home for
>> log4-server. This is not a tool. It's a runtime component. I do not see why
>> it cannot live in main repo.
>>
>> I use tools at development time. YMMV.
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>>
>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
>> JUnit in Action, Second Edition
>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>
>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
>> Spring Batch in Action
>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
>
Re: Wrong home for log4j-server stuff
Posted by Ralph Goers <ra...@dslextreme.com>.
I agree it doesn’t belong in the tools repo. It really belongs in a log4j-examples or log4j-samples as that is all it was meant to be.
Ralph
> On May 29, 2017, at 2:06 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> I find that the Git repo logging-log4j-tools is the wrong home for
> log4-server. This is not a tool. It's a runtime component. I do not see why
> it cannot live in main repo.
>
> I use tools at development time. YMMV.
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory