You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by barthel <gi...@git.apache.org> on 2014/03/14 01:00:47 UTC
[GitHub] felix pull request: Possible fix for [FELIX-4436] https://issues.a...
GitHub user barthel opened a pull request:
https://github.com/apache/felix/pull/4
Possible fix for [FELIX-4436] https://issues.apache.org/jira/browse/FELIX-4436
* handle bundle if bundle location is a opaque uri
* use 'file:' instead of last index of colon for extract the path name from opaque uri
* test added
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/barthel/felix trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 008c1c43aca0b8d10f54f6eb1bf55854128e1614
Author: Uwe Barthel <ba...@x-reizend.de>
Date: 2014-03-05T06:34:52Z
[FELIX-4436] handle bundle if bundle location is a opaque uri
commit b623ec0a2a607c4f8baa827660ba32bfdfccf09d
Author: Uwe Barthel <ba...@x-reizend.de>
Date: 2014-03-13T23:52:55Z
[FELIX-4436] handle bundle if bundle location is a opaque uri
* use 'file:' instead of last index of colon for extract the path name from opaque uri
* test added
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] felix pull request: Possible fix for [FELIX-4436] https://issues.a...
Posted by barthel <gi...@git.apache.org>.
Github user barthel closed the pull request at:
https://github.com/apache/felix/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] felix pull request: Possible fix for [FELIX-4436] https://issues.a...
Posted by Richard Hall <he...@ungoverned.org>.
It wasn't you personally that annoyed me, just the messages. I'd rather it
be an automated system to attach a patch to a JIRA issue.
My annoyance had nothing to do with git, which I use on other projects.
On Mar 14, 2014 2:51 AM, "Uwe Barthel" <ba...@x-reizend.de> wrote:
> Hi Richard,
>
> > To me, these pull request are sort of annoying, since we don't even
> use
> > git for the Felix source repo...
>
> Apologies if I have annoyed you.
> You don't need any git experience to work with this pull request.
>
> > > https://github.com/apache/felix/pull/4.patch
> Use this link to download and apply the patch via svn.
> Github does the magic if you commit these changes to svn.
>
> But, I don't like to start a discussion about git vs. svn.
> For me it is possible to upload a patch to jira instead.
>
> Regards,
> barthel
> --
> Uwe Barthel <ba...@x-reizend.de>
>
>
Re: [GitHub] felix pull request: Possible fix for [FELIX-4436]
https://issues.a...
Posted by Uwe Barthel <ba...@x-reizend.de>.
Hi Richard,
> To me, these pull request are sort of annoying, since we don't even
use
> git for the Felix source repo...
Apologies if I have annoyed you.
You don't need any git experience to work with this pull request.
> > https://github.com/apache/felix/pull/4.patch
Use this link to download and apply the patch via svn.
Github does the magic if you commit these changes to svn.
But, I don't like to start a discussion about git vs. svn.
For me it is possible to upload a patch to jira instead.
Regards,
barthel
--
Uwe Barthel <ba...@x-reizend.de>
Re: [GitHub] felix pull request: Possible fix for [FELIX-4436] https://issues.a...
Posted by "Richard S. Hall" <he...@ungoverned.org>.
To me, these pull request are sort of annoying, since we don't even use
git for the Felix source repo...
-> richard
On 3/13/14, 20:00 , barthel wrote:
> GitHub user barthel opened a pull request:
>
> https://github.com/apache/felix/pull/4
>
> Possible fix for [FELIX-4436] https://issues.apache.org/jira/browse/FELIX-4436
>
> * handle bundle if bundle location is a opaque uri
> * use 'file:' instead of last index of colon for extract the path name from opaque uri
> * test added
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/barthel/felix trunk
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/felix/pull/4.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #4
>
> ----
> commit 008c1c43aca0b8d10f54f6eb1bf55854128e1614
> Author: Uwe Barthel <ba...@x-reizend.de>
> Date: 2014-03-05T06:34:52Z
>
> [FELIX-4436] handle bundle if bundle location is a opaque uri
>
> commit b623ec0a2a607c4f8baa827660ba32bfdfccf09d
> Author: Uwe Barthel <ba...@x-reizend.de>
> Date: 2014-03-13T23:52:55Z
>
> [FELIX-4436] handle bundle if bundle location is a opaque uri
> * use 'file:' instead of last index of colon for extract the path name from opaque uri
> * test added
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---