You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ar...@apache.org on 2008/04/18 10:43:57 UTC
svn commit: r649409 - in
/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid:
client/AMQConnection.java client/BasicMessageProducer_0_10.java
client/ClientProperties.java jms/ConnectionURL.java
Author: arnaudsimon
Date: Fri Apr 18 01:43:53 2008
New Revision: 649409
URL: http://svn.apache.org/viewvc?rev=649409&view=rev
Log:
QPID-798 Make property per connection and/or system wide; change name to SYNC_PERSISTENT to denote only used on persistent messages
Modified:
incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java
incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/ClientProperties.java
incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/ConnectionURL.java
Modified: incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java?rev=649409&r1=649408&r2=649409&view=diff
==============================================================================
--- incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java (original)
+++ incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java Fri Apr 18 01:43:53 2008
@@ -155,6 +155,9 @@
// this connection maximum number of prefetched messages
private long _maxPrefetch;
+ //Indicates whether persistent messages are synchronized
+ private boolean _syncPersistence;
+
/**
* @param broker brokerdetails
* @param username username
@@ -245,6 +248,16 @@
_maxPrefetch = ClientProperties.MAX_PREFETCH;
}
+ if (connectionURL.getOption(ConnectionURL.AMQ_SYNC_PERSISTENCE) != null)
+ {
+ _syncPersistence = Boolean.parseBoolean(connectionURL.getOption(ConnectionURL.AMQ_MAXPREFETCH));
+ }
+ else
+ {
+ // use the defaul value set for all connections
+ _syncPersistence = ClientProperties.SYNC_PERSISTENT;
+ }
+
_failoverPolicy = new FailoverPolicy(connectionURL);
if (_failoverPolicy.getCurrentBrokerDetails().getTransport().equals(BrokerDetails.VM))
{
@@ -1202,5 +1215,15 @@
public long getMaxPrefetch()
{
return _maxPrefetch;
+ }
+
+ /**
+ * Indicates whether persistent messages are synchronized
+ *
+ * @return true if persistent messages are synchronized false otherwise
+ */
+ public boolean getSyncPersistence()
+ {
+ return _syncPersistence;
}
}
Modified: incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java?rev=649409&r1=649408&r2=649409&view=diff
==============================================================================
--- incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java (original)
+++ incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java Fri Apr 18 01:43:53 2008
@@ -218,7 +218,7 @@
message.get010Message(),
org.apache.qpidity.nclient.Session.TRANSFER_CONFIRM_MODE_NOT_REQUIRED,
org.apache.qpidity.nclient.Session.TRANSFER_ACQUIRE_MODE_PRE_ACQUIRE);
- if(deliveryMode == DeliveryMode.PERSISTENT && ClientProperties.FULLY_SYNC )
+ if(deliveryMode == DeliveryMode.PERSISTENT && getSession().getAMQConnection().getSyncPersistence())
{
// we need to sync the delivery of this message
((AMQSession_0_10) getSession()).getQpidSession().sync();
Modified: incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/ClientProperties.java
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/ClientProperties.java?rev=649409&r1=649408&r2=649409&view=diff
==============================================================================
--- incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/ClientProperties.java (original)
+++ incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/ClientProperties.java Fri Apr 18 01:43:53 2008
@@ -32,5 +32,5 @@
/**
* When true a sync command is sent after every persistent messages.
*/
- public static boolean FULLY_SYNC = Boolean.getBoolean("fully_sync");
+ public static boolean SYNC_PERSISTENT = Boolean.getBoolean("sync_persistence");
}
Modified: incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/ConnectionURL.java
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/ConnectionURL.java?rev=649409&r1=649408&r2=649409&view=diff
==============================================================================
--- incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/ConnectionURL.java (original)
+++ incubator/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/jms/ConnectionURL.java Fri Apr 18 01:43:53 2008
@@ -32,6 +32,7 @@
*/
public interface ConnectionURL
{
+ public static final String AMQ_SYNC_PERSISTENCE = "sync_persistence";
public static final String AMQ_MAXPREFETCH = "maxprefetch";
public static final String AMQ_PROTOCOL = "amqp";
public static final String OPTIONS_BROKERLIST = "brokerlist";