You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/11/20 19:55:28 UTC

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #2075: LUCENE-9599 Disable sort optim on index sort

mayya-sharipova commented on pull request #2075:
URL: https://github.com/apache/lucene-solr/pull/2075#issuecomment-731377310


   I've caught with @jimczi offline, and we have decided that  as all index segments are sorted in the same way, `TopFieldCollector` should inform `FieldComparator`  about index sort only once and not for every leaf.
   This change is reflected in 5aa08f51b.
   
   For 8.x branch `FieldComparator::usesIndexSort` method will be combined into [FieldComparator::setCanUsePoints](https://github.com/apache/lucene-solr/blob/branch_8x/lucene/core/src/java/org/apache/lucene/search/FieldComparator.java#L152)
   
   @jimczi This PR is ready for another round of review, please review when you have time


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org