You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2025/03/03 07:29:06 UTC
[PR] [To dev/1.3] Pipe: implement AutoCloseable for insert node event and raw tablet event & Subscription: add parameter control tablet event batch estimate & close memory block in tablet event for iteration snapshot (#14991) [iotdb]
SteveYurongSu opened a new pull request, #15001:
URL: https://github.com/apache/iotdb/pull/15001
(cherry picked from commit c5a2e4364f42f5c644c8aa165466dd8cd5449d65)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3] Pipe: implement AutoCloseable for insert node event and raw tablet event & Subscription: add parameter control tablet event batch estimate & close memory block in tablet event for iteration snapshot (#14991) [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #15001:
URL: https://github.com/apache/iotdb/pull/15001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3] Pipe: implement AutoCloseable for insert node event and raw tablet event & Subscription: add parameter control tablet event batch estimate & close memory block in tablet event for iteration snapshot (#14991) [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #15001:
URL: https://github.com/apache/iotdb/pull/15001#issuecomment-2693586931
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/15001?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `35.78947%` with `61 lines` in your changes missing coverage. Please review.
> Project coverage is 41.44%. Comparing base [(`ae56736`)](https://app.codecov.io/gh/apache/iotdb/commit/ae56736261e5366c26082e090e37ca3fef9a770a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`bfaeb53`)](https://app.codecov.io/gh/apache/iotdb/commit/bfaeb5348b5749eb4ef6e93dec878c055d23dbcd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on dev/1.3.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/15001?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...mon/tablet/PipeInsertNodeTabletInsertionEvent.java](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fevent%2Fcommon%2Ftablet%2FPipeInsertNodeTabletInsertionEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9ldmVudC9jb21tb24vdGFibGV0L1BpcGVJbnNlcnROb2RlVGFibGV0SW5zZXJ0aW9uRXZlbnQuamF2YQ==) | 29.16% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../event/batch/SubscriptionPipeTabletEventBatch.java](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fsubscription%2Fevent%2Fbatch%2FSubscriptionPipeTabletEventBatch.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3Vic2NyaXB0aW9uL2V2ZW50L2JhdGNoL1N1YnNjcmlwdGlvblBpcGVUYWJsZXRFdmVudEJhdGNoLmphdmE=) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...batch/SubscriptionPipeTabletIterationSnapshot.java](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fsubscription%2Fevent%2Fbatch%2FSubscriptionPipeTabletIterationSnapshot.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3Vic2NyaXB0aW9uL2V2ZW50L2JhdGNoL1N1YnNjcmlwdGlvblBpcGVUYWJsZXRJdGVyYXRpb25TbmFwc2hvdC5qYXZh) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ommons/subscription/config/SubscriptionConfig.java](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fsubscription%2Fconfig%2FSubscriptionConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvc3Vic2NyaXB0aW9uL2NvbmZpZy9TdWJzY3JpcHRpb25Db25maWcuamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ent/common/tablet/PipeRawTabletInsertionEvent.java](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fevent%2Fcommon%2Ftablet%2FPipeRawTabletInsertionEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9ldmVudC9jb21tb24vdGFibGV0L1BpcGVSYXdUYWJsZXRJbnNlcnRpb25FdmVudC5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/15001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev/1.3 #15001 +/- ##
=============================================
+ Coverage 41.42% 41.44% +0.01%
Complexity 193 193
=============================================
Files 3546 3546
Lines 228085 228141 +56
Branches 27293 27291 -2
=============================================
+ Hits 94494 94546 +52
- Misses 133591 133595 +4
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/15001?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3] Pipe: implement AutoCloseable for insert node event and raw tablet event & Subscription: add parameter control tablet event batch estimate & close memory block in tablet event for iteration snapshot (#14991) [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15001:
URL: https://github.com/apache/iotdb/pull/15001#issuecomment-2693515198
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15001) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=15001&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=15001&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=15001&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15001&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15001&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15001)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org