You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Bill Graham (JIRA)" <ji...@apache.org> on 2009/07/23 08:15:15 UTC
[jira] Created: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Integrate JDBC driver with SQuirrelSQL for querying
---------------------------------------------------
Key: HIVE-679
URL: https://issues.apache.org/jira/browse/HIVE-679
Project: Hadoop Hive
Issue Type: New Feature
Components: Clients
Reporter: Bill Graham
Assignee: Bill Graham
Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741422#action_12741422 ]
Bill Graham commented on HIVE-679:
----------------------------------
Hey Raghu,
Was just looking through the code to try to find the indentation issues you
referenced and I can't find any. Where were you seeing issues?
thanks,
Bill
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742121#action_12742121 ]
Raghotham Murthy commented on HIVE-679:
---------------------------------------
@Bill
One possibility is to extract the latest version from CHANGES.txt (potentially including CHANGES.txt in an installation). This file has to be modified for every release anyway.
Regarding, indentation issues - I think spaces have be replaced by tabs.
1. comment for maxRows in HiveStatement.java
2. In HiveDriver.java: getPropertyInfo, parseURL
I also noticed that you include serde.Constants in HiveResultSetMetaData.java. Do you need that?
Also, after HIVE-736, you can get hive types of the result set by calling getSchema(). getThriftSchema() return thrift types.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghotham Murthy updated HIVE-679:
----------------------------------
Tags: jdbc
Resolution: Fixed
Fix Version/s: 0.4.0
Release Note:
HIVE-679. Adding the basic JDBC methods to allow querying using the SQuirrelSQL tool. (Bill Graham via rmurthy)
was:Adding the basic JDBC methods to allow querying using the SQuirrelSQL tool.
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to both trunk and branch-0.4. Thanks Bill!
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.4.0
>
> Attachments: HIVE-679.1.patch, HIVE-679.2.branch-0.4.patch, HIVE-679.2.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739952#action_12739952 ]
Ashish Thusoo commented on HIVE-679:
------------------------------------
Looks good from the first pass. I am going to look at it more closely tomorrow. I had a minor question around the APIs returning the database version and the driver version. Should the former reflect the hive version. Thoughts?
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745857#action_12745857 ]
Raghotham Murthy commented on HIVE-679:
---------------------------------------
looks good. will commit if tests pass.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch, HIVE-679.2.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741383#action_12741383 ]
Bill Graham commented on HIVE-679:
----------------------------------
Yes, database version should come from the Hive Server. Is this currently being returned by the server?
Regarding the driver version I see two possible options: 1.) We use the svn revision number as the version or 2.) We use the release version (i.e., 4.0). The former would be easiest to support of course, since the latter would probably require a hard-coded constant that needs to change from release to release. Any opinions either way?
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated HIVE-679:
-----------------------------
Attachment: HIVE-679.2.branch-0.4.patch
Attaching patch for 4.0 branch and just did the same for dependent JIRA HIVE-760. (My last comment re HIVE-569 was a typo, should have read HIVE-760).
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch, HIVE-679.2.branch-0.4.patch, HIVE-679.2.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739239#action_12739239 ]
Bill Graham commented on HIVE-679:
----------------------------------
Ping. Has anyone had a chance to review this patch? Please let me know if there are changes that are needed.
Also note that there should have been two asterisks in my comment above (note 2c) that got interpreted as bold formatting.
Another note, when testing this patch, you will see some "method not implemented" exceptions in the logs when connecting to Hive, since much of DatabaseMetadata is un-implemented. Once connected though, you shouldn't see exceptions when executing queries.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated HIVE-679:
-----------------------------
Attachment: HIVE-679.2.patch
@Raghu I follow you now. My terminology was causing confusions. I'm currently getting _Thrift_ types back from HiveResultSet.initDynamicSerde(), not _Hive_ types. Then I convert. You're suggesting to just return the Hive types from the server. I agree this is the best approach, but think it makes most sense get this JDBC functionality committed as-is, and then take on the Hive server getHiveTypes() work and JDBC refactoring as a separate JIRA.
Submitting HIVE-679.2.patch which includes support for HiveDatabaseMetaData.getDriverVersion() and getDriverName() reading it's values from the jar manifest file.
I'll update the wiki with instructions.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch, HIVE-679.2.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742153#action_12742153 ]
Bill Graham commented on HIVE-679:
----------------------------------
Thanks for the comments and for catching those tabs.
We could use CHANGES.txt for the driver version, but I think the solution should be done at build time, instead of runtime. It seems like an undesirable dependency to have a txt file bundled in the hive_jdbc.jar that has to be read at runtime somehow. If it was done at build time though, we'd need to do some token substitution in the java source before compiling to insert the version taken from CHANGES.txt. Also not the prettiest, but I think the end result would be better. What do you think?
I'm importing serdeConstants for the getColumnTypeName method, which converts Thrift types to Hive types. I debated hardcoding the Hive types in HiveResultSetMetaData to avoid the dependency, but since serde is already required by hive_jdbc elsewhere, I used serde.Contants.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743519#action_12743519 ]
Ashish Thusoo commented on HIVE-679:
------------------------------------
You could just include the constant in the manifest file of the jar and pick it from there. That would probably work and of course the manifest file would be generated at compile time.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-679:
--------------------------------
Component/s: Drivers
(was: Clients)
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Drivers
> Reporter: Bill Graham
> Assignee: Bill Graham
> Fix For: 0.4.0
>
> Attachments: HIVE-679.1.patch, HIVE-679.2.branch-0.4.patch, HIVE-679.2.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746525#action_12746525 ]
Raghotham Murthy commented on HIVE-679:
---------------------------------------
Patch to branch-0.4 looks good. Will commit if tests pass.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch, HIVE-679.2.branch-0.4.patch, HIVE-679.2.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740418#action_12740418 ]
Bill Graham commented on HIVE-679:
----------------------------------
I'd think the database version should be the version of Hive returned from the Hive Server. The later should be the version of the compiled driver. I have "0" in there for both currently, which is what's been done elsewhere in the code. How about we follow this precedent for now to get some reasonable JDBC functionality supported, then create another JIRA to work out metadata versioning in it's entirety? It would be nice to get this into the 4.0 release... :)
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741043#action_12741043 ]
Raghotham Murthy commented on HIVE-679:
---------------------------------------
The patch does look good. Regarding versioning, does it make sense to just get all the versions from the HiveServer? Then the JDBC driver itself will need to have just the client version.
You may have to regenerate it since HIVE-736 modified the same files. Also, there seem to be some indentation issues. Finally, can you add a section to http://wiki.apache.org/hadoop/Hive/HiveJDBCInterface with instructions to integrate with SQuirrelSQL?
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734478#action_12734478 ]
Bill Graham commented on HIVE-679:
----------------------------------
SQuirrelSQL allows a connection to be established without support for DatabaseMetaData, which is being handled separately as part of HIVE-576. That allows work on this issue to occur in parallel, ignoring the DatabaseMetaData support in SQuirrelSQL.
I've got this working in my dev env with unit tests and will submit a patch soon. Below is the scope of what I've had to implement:
HiveStatement
- getWarnings(), clearWarnings()
- close(), isClosed()
- execute(), getResultSet()
- getUpdateCount()
- setMaxRows()
HiveConnection
- getWarnings(), clearWarnings()
- close(), isClosed()
HiveDatabaseMetaData
- getDatabaseProductName() : Hive, getDatabaseProductVersion() : 0
- getProcedures() : null
- supportsCatalogsInTableDefinitions() : false
- supportsSchemasInTableDefinitions() : false
- supportsMultipleResultSets() : false
- supportsStoredProcedures() : false
HiveDriver
- getPropertyInfo : returns HOST, PORT, DBNAME properties
HiveResultSet
- getWarnings(), clearWarnings()
- wasNull()
- initializing column names and types
- support for maxRows
- Constructor throws SQLException instead of calling System.exit(1) on error
HiveResultSetMetaData
- getColumnType(int column)
- getColumnTypeName(int column)
- getColumnDisplaySize(int column)
- isAutoIncrement(int column) : false
- isCurrency(int column) : false
- isNullable(int column) : false
- getPrecision(int column) : 0 or -1 for DOUBLE ??? What should double precision be?
- getScale(int column) : 0 or -1 for DOUBLE ??? What should double scope be?
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated HIVE-679:
-----------------------------
Attachment: HIVE-679.1.patch
Adding HIVE-679.1.patch. To test, apply the patch and install/run SQuirrelSQL (I've tested with MacOSx v.3.0.2):
1. Download and install SQuirrelSQL from http://www.squirrelsql.org/#installation
2. Start SQuirrelSQL and add the Hive driver
a. Select Drivers --> New Driver
b. Name the driver
c. From the 'Extra Class Path' tab add HIVE_HOME/lib/*.jar, and HADOOP_HOME/hadoop-*-core.jar
d. Enter Class Name: org.apache.hadoop.hive.jdbc.HiveDriver
3. Create a new connection a the Hive server
a. Select Aliases --> New Alias
b. Name the connection, select the Hive driver and enter your Hive server URL
c. Test the connection
4. From the Aliases tab on the left, connect to the Hive alias.
You should now be able to do basic querying (i.e. show tables, describe table, select, create, drop, etc).
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746512#action_12746512 ]
Raghotham Murthy commented on HIVE-679:
---------------------------------------
Yes. Please submit a patch against 0.4 as well and I'll commit it to the branch.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch, HIVE-679.2.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744075#action_12744075 ]
Raghotham Murthy commented on HIVE-679:
---------------------------------------
@bill, Ashish's suggestion about the manifest file seems good. Also, regarding serde.Constants, it seems better to get the hive types from the server. How about adding an enumeration to serde/if/serde.thrift and returning that from the hive server via a getHiveTypes() call. This method can also be used by ODBC.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Graham updated HIVE-679:
-----------------------------
Release Note: Adding the basic JDBC methods to allow querying using the SQuirrelSQL tool.
Status: Patch Available (was: Open)
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734480#action_12734480 ]
Bill Graham commented on HIVE-679:
----------------------------------
Typo above. Should be HiveResultSetMetaData.isNullable(int column) : true
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745814#action_12745814 ]
Bill Graham commented on HIVE-679:
----------------------------------
Wiki updated: http://wiki.apache.org/hadoop/Hive/HiveJDBCInterface
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch, HIVE-679.2.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745725#action_12745725 ]
Raghotham Murthy commented on HIVE-679:
---------------------------------------
I meant that we need a method, getHiveTypes() in hive server which will return whatever serde.Constants has. That way you wont have to depend on serde. This method can also be used by the ODBC driver instead of creating its own C enumeration. Does that make sense?
Maybe you can do that as part of a separate jira. Then, I am fine with this change. Please do add instructions at: http://wiki.apache.org/hadoop/Hive/HiveJDBCInterface
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-679) Integrate JDBC driver with SQuirrelSQL
for querying
Posted by "Bill Graham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744127#action_12744127 ]
Bill Graham commented on HIVE-679:
----------------------------------
Yes, good call on using the manifest. I've opened JIRA-760 and will submit a patch soon.
@Raghu, I am getting the Hive Types from the server in HiveResultSet.initDynamicSerde() using the following pre-existing code:
<code>
Schema fullSchema = client.getThriftSchema();
List<FieldSchema> schema = fullSchema.getFieldSchemas();
</code>
I need the constants on the client to map what the server returns to the JDBC types. Are you suggesting the server return JDBC types as well as Hive Types? Otherwise I'll still need constants on the client. I think I'm not entirely following your suggestion.
> Integrate JDBC driver with SQuirrelSQL for querying
> ---------------------------------------------------
>
> Key: HIVE-679
> URL: https://issues.apache.org/jira/browse/HIVE-679
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Clients
> Reporter: Bill Graham
> Assignee: Bill Graham
> Attachments: HIVE-679.1.patch
>
>
> Implement the JDBC methods required to support querying and other basic commands using the SQuirrelSQL tool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.