You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/19 00:24:01 UTC
[GitHub] [spark] maropu opened a new pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
maropu opened a new pull request #31888:
URL: https://github.com/apache/spark/pull/31888
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Use `Utils.getSimpleName` to avoid hitting `Malformed class name` error in `NewInstance.doGenCode`.
This is the backport PR of #31709 and the credit should be @rednaxelafx .
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
On older JDK versions (e.g. JDK8u), nested Scala classes may trigger `java.lang.Class.getSimpleName` to throw an `java.lang.InternalError: Malformed class name` error.
In this particular case, creating an `ExpressionEncoder` on such a nested Scala class would create a `NewInstance` expression under the hood, which will trigger the problem during codegen.
Similar to https://github.com/apache/spark/pull/29050, we should use Spark's `Utils.getSimpleName` utility function in place of `Class.getSimpleName` to avoid hitting the issue.
There are two other occurrences of `java.lang.Class.getSimpleName` in the same file, but they're safe because they're only guaranteed to be only used on Java classes, which don't have this problem, e.g.:
```scala
// Make a copy of the data if it's unsafe-backed
def makeCopyIfInstanceOf(clazz: Class[_ <: Any], value: String) =
s"$value instanceof ${clazz.getSimpleName}? ${value}.copy() : $value"
val genFunctionValue: String = lambdaFunction.dataType match {
case StructType(_) => makeCopyIfInstanceOf(classOf[UnsafeRow], genFunction.value)
case ArrayType(_, _) => makeCopyIfInstanceOf(classOf[UnsafeArrayData], genFunction.value)
case MapType(_, _, _) => makeCopyIfInstanceOf(classOf[UnsafeMapData], genFunction.value)
case _ => genFunction.value
}
```
The Unsafe-* family of types are all Java types, so they're okay.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Fixes a bug that throws an error when using `ExpressionEncoder` on some nested Scala types, otherwise no changes.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a test case to `org.apache.spark.sql.catalyst.encoders.ExpressionEncoderSuite`. It'll fail on JDK8u before the fix, and pass after the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803240022
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40857/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803226591
```
NOTE: branch-2.4 does not have the interpreted implementation of SafeProjection, so it does not fall back into
the interpreted mode if the compilation fails. Therefore, the test in this PR just checks that the compilation
error happens instead of checking that the interpreted mode works well.
```
@viirya okay, I updated it and please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-805601661
cc @cloud-fan @dongjoon-hyun too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-802456048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-802648869
lgtm if we clearly state why we change the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-802648623
@maropu Can you add few words about why you change the test case? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-802648623
@maropu Can you add few words about why you add the test case? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803250984
**[Test build #136275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136275/testReport)** for PR 31888 at commit [`5152fff`](https://github.com/apache/spark/commit/5152fffc7344f98d1c9c83d35f219e2855bc4cff).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803256826
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136275/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803224901
sure, I'll update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31888:
URL: https://github.com/apache/spark/pull/31888#discussion_r598974589
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
##########
@@ -203,6 +203,36 @@ class ExpressionEncoderSuite extends CodegenInterpretedPlanTest with AnalysisTes
encodeDecodeTest(Array(Option(InnerClass(1))), "array of optional inner class")
+ // NOTE: branch-2.4 does not have the interpreted implementation of SafeProjection, so
+ // it does not fall back into the interpreted mode if the compilation fails.
+ // Therefore, the test in this PR just checks that the compilation error happens
+ // instead of checking that the interpreted mode works well.
+ private def checkCompilationError[T : ExpressionEncoder](
+ input: T,
+ testName: String): Unit = {
+ testAndVerifyNotLeakingReflectionObjects(s"compilation error: $testName: $input") {
+ val encoder = implicitly[ExpressionEncoder[T]]
+ val row = encoder.toRow(input)
+ val boundEncoder = encoder.resolveAndBind()
+ val errMsg = intercept[RuntimeException] {
+ boundEncoder.fromRow(row)
+ }.getCause.getMessage
+ assert(errMsg.contains("failed to compile: "))
Review comment:
Is this the compilation error?
```
[info] Cause: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 32, Column 124: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 32, Column 124: "org.apache.
spark.sql.catalyst.encoders.ExpressionEncoderSuite$MalformedClassObject$" has no member type "ExpressionEncoderSuite$MalformedClassObject$MalformedNameExample"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31888:
URL: https://github.com/apache/spark/pull/31888#discussion_r599324821
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
##########
@@ -203,6 +203,36 @@ class ExpressionEncoderSuite extends CodegenInterpretedPlanTest with AnalysisTes
encodeDecodeTest(Array(Option(InnerClass(1))), "array of optional inner class")
+ // NOTE: branch-2.4 does not have the interpreted implementation of SafeProjection, so
+ // it does not fall back into the interpreted mode if the compilation fails.
+ // Therefore, the test in this PR just checks that the compilation error happens
+ // instead of checking that the interpreted mode works well.
+ private def checkCompilationError[T : ExpressionEncoder](
+ input: T,
+ testName: String): Unit = {
+ testAndVerifyNotLeakingReflectionObjects(s"compilation error: $testName: $input") {
+ val encoder = implicitly[ExpressionEncoder[T]]
+ val row = encoder.toRow(input)
+ val boundEncoder = encoder.resolveAndBind()
+ val errMsg = intercept[RuntimeException] {
+ boundEncoder.fromRow(row)
+ }.getCause.getMessage
+ assert(errMsg.contains("failed to compile: "))
Review comment:
> Is this the compilation error?
Yea, that's the expected error. Actually, the master has same error when `useFallback = false`:
https://github.com/apache/spark/blob/d32bb4e5ee4718741252c46c50a40810b722f12d/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala#L219
```
// master
[info] Cause: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 32, Column 124: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 32, Column 124: "org.apache.spark.sql.catalyst.encoders.ExpressionEncoderSuite$MalformedClassObject$" has no member type "ExpressionEncoderSuite$MalformedClassObject$MalformedNameExample"
[info] at org.apache.spark.sql.errors.QueryExecutionErrors$.compilerError(QueryExecutionErrors.scala:328)
```
> But by moving MalformedClassObject out of ExpressionEncoderSuite, the generated code can be compiled.
IIUC the condition where the error happens is that `MalformedClassObject` is placed in `ExpressionEncoderSuite` as Kris said in the previous PR: https://github.com/apache/spark/pull/31709#issuecomment-791275810
```
Actually, what's more interesting is the different rules of Java's nested classes and Scala's. Since there is no such
notion of a "companion object" or built-in "singleton object" notion on the Java language level, at least not in
Java 8, the Java language syntax for creating a new instance of a inner class object doesn't work well for Scala's
class Foo { object Bar { class Baz {...} } } kind of nesting, i.e. even when we do use the correct "simple name"
(e.g. MalformedNameExample), there would still be no valid Java syntax to create it (i.e. outerObj.new
InnerClass(...) doesn't work when outerObj is a Scala object)
```
cc: @rednaxelafx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #31888:
URL: https://github.com/apache/spark/pull/31888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-806024469
Thanks all. Merging to 2.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803226591
@viirya okay, I updated it and please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-802410529
cc: @viirya @rednaxelafx
NOTE: This PR comes from the discussion with @viirya https://github.com/apache/spark/pull/31747#issuecomment-799938197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-805604550
I will merge this tomorrow if no more comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803237118
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40857/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31888:
URL: https://github.com/apache/spark/pull/31888#discussion_r598979104
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
##########
@@ -203,6 +203,36 @@ class ExpressionEncoderSuite extends CodegenInterpretedPlanTest with AnalysisTes
encodeDecodeTest(Array(Option(InnerClass(1))), "array of optional inner class")
+ // NOTE: branch-2.4 does not have the interpreted implementation of SafeProjection, so
+ // it does not fall back into the interpreted mode if the compilation fails.
+ // Therefore, the test in this PR just checks that the compilation error happens
+ // instead of checking that the interpreted mode works well.
+ private def checkCompilationError[T : ExpressionEncoder](
+ input: T,
+ testName: String): Unit = {
+ testAndVerifyNotLeakingReflectionObjects(s"compilation error: $testName: $input") {
+ val encoder = implicitly[ExpressionEncoder[T]]
+ val row = encoder.toRow(input)
+ val boundEncoder = encoder.resolveAndBind()
+ val errMsg = intercept[RuntimeException] {
+ boundEncoder.fromRow(row)
+ }.getCause.getMessage
+ assert(errMsg.contains("failed to compile: "))
Review comment:
But by moving `MalformedClassObject` out of `ExpressionEncoderSuite`, the generated code can be compiled.
I'm not sure what this test wants to test actually. Am I confused or do I misunderstand it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803240022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-802648623
@maropu Can you add few words to the PR description about why you change the test case? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-802456048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803226641
**[Test build #136275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136275/testReport)** for PR 31888 at commit [`5152fff`](https://github.com/apache/spark/commit/5152fffc7344f98d1c9c83d35f219e2855bc4cff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803230441
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40857/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #31888:
URL: https://github.com/apache/spark/pull/31888#discussion_r600259507
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
##########
@@ -203,6 +203,36 @@ class ExpressionEncoderSuite extends CodegenInterpretedPlanTest with AnalysisTes
encodeDecodeTest(Array(Option(InnerClass(1))), "array of optional inner class")
+ // NOTE: branch-2.4 does not have the interpreted implementation of SafeProjection, so
+ // it does not fall back into the interpreted mode if the compilation fails.
+ // Therefore, the test in this PR just checks that the compilation error happens
+ // instead of checking that the interpreted mode works well.
+ private def checkCompilationError[T : ExpressionEncoder](
+ input: T,
+ testName: String): Unit = {
+ testAndVerifyNotLeakingReflectionObjects(s"compilation error: $testName: $input") {
+ val encoder = implicitly[ExpressionEncoder[T]]
+ val row = encoder.toRow(input)
+ val boundEncoder = encoder.resolveAndBind()
+ val errMsg = intercept[RuntimeException] {
+ boundEncoder.fromRow(row)
+ }.getCause.getMessage
+ assert(errMsg.contains("failed to compile: "))
Review comment:
Got it. Thanks for the reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31888: [SPARK-34596][SQL][2.4] Use Utils.getSimpleName to avoid hitting Malformed class name in NewInstance.doGenCode
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31888:
URL: https://github.com/apache/spark/pull/31888#issuecomment-803226641
**[Test build #136275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136275/testReport)** for PR 31888 at commit [`5152fff`](https://github.com/apache/spark/commit/5152fffc7344f98d1c9c83d35f219e2855bc4cff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org