You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2021/05/10 09:29:10 UTC

[echarts] branch enhance-visual-regression-test updated (dcf48f2 -> e43623d)

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a change to branch enhance-visual-regression-test
in repository https://gitbox.apache.org/repos/asf/echarts.git.


    from dcf48f2  test(visual): use threads in cli instead of server
     new 1393224  test(visual): fix echarts lib download
     new e43623d  test(visual): update fs-extra version

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 package-lock.json                 | 38 +++++++++++++++++---------------------
 package.json                      |  2 +-
 test/runTest/actions/allZero.json |  2 +-
 test/runTest/cli.js               |  4 +++-
 test/runTest/util.js              |  2 +-
 5 files changed, 23 insertions(+), 25 deletions(-)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[echarts] 01/02: test(visual): fix echarts lib download

Posted by sh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch enhance-visual-regression-test
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit 13932242a30de1f8e7dd319cd6c32cd7f02d39c7
Author: pissang <bm...@gmail.com>
AuthorDate: Mon May 10 15:18:12 2021 +0800

    test(visual): fix echarts lib download
---
 test/runTest/util.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/runTest/util.js b/test/runTest/util.js
index de31b41..b116c49 100644
--- a/test/runTest/util.js
+++ b/test/runTest/util.js
@@ -72,7 +72,7 @@ module.exports.prepareEChartsLib = function (version) {
     return new Promise(resolve => {
         const testLibPath = `${versionFolder}/${module.exports.getEChartsTestFileName()}`;
         if (!fs.existsSync(ecDownloadPath)) {
-            const file = fs.createWriteStream();
+            const file = fs.createWriteStream(ecDownloadPath);
             const isNightly = version.includes('-dev');
             const packageName = isNightly ? 'echarts-nightly' : 'echarts'
 

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[echarts] 02/02: test(visual): update fs-extra version

Posted by sh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch enhance-visual-regression-test
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit e43623daf8aec43b2c794293bc615b27ff722fa3
Author: pissang <bm...@gmail.com>
AuthorDate: Mon May 10 16:40:54 2021 +0800

    test(visual): update fs-extra version
---
 package-lock.json                 | 38 +++++++++++++++++---------------------
 package.json                      |  2 +-
 test/runTest/actions/allZero.json |  2 +-
 test/runTest/cli.js               |  4 +++-
 4 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 662f997..40da27d 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -4848,26 +4848,31 @@
       "dev": true
     },
     "fs-extra": {
-      "version": "0.26.7",
-      "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-0.26.7.tgz",
-      "integrity": "sha1-muH92UiXeY7at20JGM9C0MMYT6k=",
+      "version": "10.0.0",
+      "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-10.0.0.tgz",
+      "integrity": "sha512-C5owb14u9eJwizKGdchcDUQeFtlSHHthBk8pbX9Vc1PFZrLombudjDnNns88aYslCyF6IY5SUw3Roz6xShcEIQ==",
       "dev": true,
       "requires": {
-        "graceful-fs": "^4.1.2",
-        "jsonfile": "^2.1.0",
-        "klaw": "^1.0.0",
-        "path-is-absolute": "^1.0.0",
-        "rimraf": "^2.2.8"
+        "graceful-fs": "^4.2.0",
+        "jsonfile": "^6.0.1",
+        "universalify": "^2.0.0"
       },
       "dependencies": {
         "jsonfile": {
-          "version": "2.4.0",
-          "resolved": "https://registry.npmjs.org/jsonfile/-/jsonfile-2.4.0.tgz",
-          "integrity": "sha1-NzaitCi4e72gzIO1P6PWM6NcKug=",
+          "version": "6.1.0",
+          "resolved": "https://registry.npmjs.org/jsonfile/-/jsonfile-6.1.0.tgz",
+          "integrity": "sha512-5dgndWOriYSm5cnYaJNhalLNDKOqFwyDB/rr1E9ZsGciGvKPs8R2xYGCacuf3z6K1YKDz182fd+fY3cn3pMqXQ==",
           "dev": true,
           "requires": {
-            "graceful-fs": "^4.1.6"
+            "graceful-fs": "^4.1.6",
+            "universalify": "^2.0.0"
           }
+        },
+        "universalify": {
+          "version": "2.0.0",
+          "resolved": "https://registry.npmjs.org/universalify/-/universalify-2.0.0.tgz",
+          "integrity": "sha512-hAZsKq7Yy11Zu1DE0OzWjw7nnLZmJZYTDZZyEFHZdUhV8FkH5MCfoU1XMaxXovpyW5nq5scPqq0ZDP9Zyl04oQ==",
+          "dev": true
         }
       }
     },
@@ -7450,15 +7455,6 @@
       "integrity": "sha512-dcS1ul+9tmeD95T+x28/ehLgd9mENa3LsvDTtzm3vyBEO7RPptvAD+t44WVXaUjTBRcrpFeFlC8WCruUR456hw==",
       "dev": true
     },
-    "klaw": {
-      "version": "1.3.1",
-      "resolved": "https://registry.npmjs.org/klaw/-/klaw-1.3.1.tgz",
-      "integrity": "sha1-QIhDO0azsbolnXh4XY6W9zugJDk=",
-      "dev": true,
-      "requires": {
-        "graceful-fs": "^4.1.9"
-      }
-    },
     "kleur": {
       "version": "3.0.3",
       "resolved": "https://registry.npmjs.org/kleur/-/kleur-3.0.3.tgz",
diff --git a/package.json b/package.json
index 26d61ad..6abe9e7 100644
--- a/package.json
+++ b/package.json
@@ -85,7 +85,7 @@
     "dtslint": "^4.0.5",
     "esbuild": "^0.8.39",
     "eslint": "^7.15.0",
-    "fs-extra": "0.26.7",
+    "fs-extra": "^10.0.0",
     "glob": "7.0.0",
     "globby": "11.0.0",
     "husky": "^4.2.5",
diff --git a/test/runTest/actions/allZero.json b/test/runTest/actions/allZero.json
index 3d6974c..c09fd24 100644
--- a/test/runTest/actions/allZero.json
+++ b/test/runTest/actions/allZero.json
@@ -1 +1 @@
-[{"name":"Action 2","ops":[{"type":"mousemove","time":698,"x":192,"y":274},{"type":"mousemove","time":899,"x":213,"y":276},{"type":"mousemove","time":1104,"x":238,"y":281},{"type":"mousemove","time":1306,"x":239,"y":281},{"type":"screenshot","time":2832},{"type":"mousemove","time":3509,"x":240,"y":281},{"type":"mousemove","time":3710,"x":271,"y":283},{"type":"mousemove","time":3923,"x":346,"y":294},{"type":"mousemove","time":4123,"x":367,"y":298},{"type":"screenshot","time":5039},{"type" [...]
\ No newline at end of file
+[{"name":"Action 1","ops":[{"type":"mousemove","time":698,"x":192,"y":274},{"type":"mousemove","time":899,"x":213,"y":276},{"type":"mousemove","time":1104,"x":238,"y":281},{"type":"mousemove","time":1306,"x":239,"y":281},{"type":"screenshot","time":2832},{"type":"mousemove","time":3509,"x":240,"y":281},{"type":"mousemove","time":3710,"x":271,"y":283},{"type":"mousemove","time":3923,"x":346,"y":294},{"type":"mousemove","time":4123,"x":367,"y":298},{"type":"screenshot","time":5039},{"type" [...]
\ No newline at end of file
diff --git a/test/runTest/cli.js b/test/runTest/cli.js
index 7ef3533..9f66faf 100644
--- a/test/runTest/cli.js
+++ b/test/runTest/cli.js
@@ -281,7 +281,9 @@ async function runTestPage(browser, testOpt, version, runtimeCode, isExpected) {
             let actContent = await fse.readFile(path.join(__dirname, 'actions', testOpt.name + '.json'));
             actions = JSON.parse(actContent);
         }
-        catch (e) {}
+        catch (e) {
+            // console.log(e);
+        }
         if (actions.length > 0) {
             try {
                 page.evaluate((actions) => {

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org