You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/23 10:12:07 UTC
[GitHub] [arrow-rs] jhorstmann opened a new pull request #1222: Remove memory-check feature
jhorstmann opened a new pull request #1222:
URL: https://github.com/apache/arrow-rs/pull/1222
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1171.
# Rationale for this change
The `memory-check` feature was supposed to help in finding memory leaks, but the corresponding test was broken for a long time, showing that it is not really used. At the same time, the actual tracking was not behind a feature gate, adding synchronization overhead to every allocation.
# What changes are included in this PR?
Removes the feature gate and the `AtomicISize` used for tracking.
# Are there any user-facing changes?
Not sure whether this should really be considered a breaking change. The only use of the feature in the `arrow-rs` code base was for a unit test, so there is no change in behavior. If someone has a dependency on `arrow-rs` with the feature active, they would need to remove that feature from their `Cargo.toml`, but there would be no other code changes required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1222: Remove memory-check feature
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1222:
URL: https://github.com/apache/arrow-rs/pull/1222#issuecomment-1019454677
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1222?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1222](https://codecov.io/gh/apache/arrow-rs/pull/1222?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00445ac) into [master](https://codecov.io/gh/apache/arrow-rs/commit/e72875e4b465f9d4eae1b852051e977488f97796?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e72875e) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/1222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1222 +/- ##
=======================================
Coverage 82.70% 82.70%
=======================================
Files 175 175
Lines 51712 51706 -6
=======================================
- Hits 42768 42764 -4
+ Misses 8944 8942 -2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/alloc/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1222/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FsbG9jL21vZC5ycw==) | `91.42% <ø> (-1.26%)` | :arrow_down: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1222/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.71% <0.00%> (+0.19%)` | :arrow_up: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1222/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1222?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1222?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e72875e...00445ac](https://codecov.io/gh/apache/arrow-rs/pull/1222?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1222: Remove memory-check feature
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1222:
URL: https://github.com/apache/arrow-rs/pull/1222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1222: Remove memory-check feature
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1222:
URL: https://github.com/apache/arrow-rs/pull/1222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1222: Remove memory-check feature
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1222:
URL: https://github.com/apache/arrow-rs/pull/1222#discussion_r790281175
##########
File path: arrow/CONTRIBUTING.md
##########
@@ -26,19 +26,6 @@ Rust [README.md](../README.md).
Please refer to [lib.rs](src/lib.rs) for an introduction to this
specific crate and its current functionality.
-### How to check memory allocations
Review comment:
I can't find any reference to this feature in `arrow` either (bolstering the case that this isn't used)
https://github.com/apache/arrow/search?q=memory_check
https://github.com/apache/arrow/search?q=memory-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1222: Remove memory-check feature
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1222:
URL: https://github.com/apache/arrow-rs/pull/1222#issuecomment-1020463923
Nice cleanup -- thanks again @jhorstmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1222: Remove memory-check feature
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1222:
URL: https://github.com/apache/arrow-rs/pull/1222#issuecomment-1020463923
Nice cleanup -- thanks again @jhorstmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org