You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/06/01 23:21:18 UTC
[GitHub] beam pull request #3282: [BEAM-3271] Improve Splittable ParDo translation
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3282
[BEAM-3271] Improve Splittable ParDo translation
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @tgroh another one peeled off, this one is for Splittable ParDo.
It is different than the others in that this transform is not designed to be serializable, as it is only a post-surgery artifact.
It brings up again the decision to make a unified pre/post serialization API. We could simply not have one if we follow this workflow:
- serde the pipeline (now nodes have only `RawPTransform`)
- perform surgery
- serde the pipeline (`RawPTransform` "just works" and all "fresh" nodes from surgery now also contain `RawPTransform`)
- run
Just musing. This latter world means that pseudo-primitives all need registered payloads. I don't totally love this, because they may contain a bunch of stuff specific to the language of the runner and it is just boilerplate to give them payloads.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam Splittable-ParDo-translation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3282
----
commit 1ed23d407b0d9bccf449eeeec0d5026fe14d83ed
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-05-26T21:18:03Z
Fix RawPTransform translation
commit db8cf1c1e213506f3ee292affa69242e23794f9e
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-05-25T13:29:16Z
Improve Splittable ParDo translation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #3282: [BEAM-3271] Improve Splittable ParDo translation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3282
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---