You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/02/21 03:31:31 UTC
[GitHub] [yunikorn-k8shim] zhuqi-lucas opened a new pull request, #539: [YUNIKORN-1595] postTaskAllocated uses same event details for different things
zhuqi-lucas opened a new pull request, #539:
URL: https://github.com/apache/yunikorn-k8shim/pull/539
### What is this PR for?
The volume bind and pod to node bind failures use the same event content:
https://github.com/apache/yunikorn-k8shim/blob/master/pkg/cache/task.go#L383
and
https://github.com/apache/yunikorn-k8shim/blob/master/pkg/cache/task.go#L396
That is confusing, we should change the description text.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1595
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko commented on pull request #539: [YUNIKORN-1595] postTaskAllocated uses same event details for different things
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #539:
URL: https://github.com/apache/yunikorn-k8shim/pull/539#issuecomment-1442134365
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #539: [YUNIKORN-1595] postTaskAllocated uses same event details for different things
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #539:
URL: https://github.com/apache/yunikorn-k8shim/pull/539#issuecomment-1437818209
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/539?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#539](https://codecov.io/gh/apache/yunikorn-k8shim/pull/539?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (982fd53) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/9e650c6d3162190443c0cc4dee1c80f1db3a34db?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e650c6) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 69.55% 69.55%
=======================================
Files 45 45
Lines 7715 7715
=======================================
Hits 5366 5366
Misses 2153 2153
Partials 196 196
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `68.81% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko closed pull request #539: [YUNIKORN-1595] postTaskAllocated uses same event details for different things
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #539: [YUNIKORN-1595] postTaskAllocated uses same event details for different things
URL: https://github.com/apache/yunikorn-k8shim/pull/539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org