You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/08/03 05:48:14 UTC

[GitHub] [incubator-iotdb] dddddai opened a new pull request #1590: Use readLock in `getActiveRatio`

dddddai opened a new pull request #1590:
URL: https://github.com/apache/incubator-iotdb/pull/1590


   https://github.com/apache/incubator-iotdb/blob/master/server/src/main/java/org/apache/iotdb/db/conf/adapter/ActiveTimeSeriesCounter.java#L121-L134
   
   It should use readLock instead of writeLock here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] jixuan1989 merged pull request #1590: Use readLock in `getActiveRatio`

Posted by GitBox <gi...@apache.org>.

jixuan1989 merged pull request #1590:
URL: https://github.com/apache/incubator-iotdb/pull/1590


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1590: Use readLock in `getActiveRatio`

Posted by GitBox <gi...@apache.org>.

jixuan1989 commented on pull request #1590:
URL: https://github.com/apache/incubator-iotdb/pull/1590#issuecomment-670304024


   Thanks for your contribution!
   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org