[GitHub] srdo opened a new pull request #2959: STORM-3342: Add license-maven-plugin configuration, and describe how …

[GitBox <gi...@apache.org>]

srdo opened a new pull request #2959: STORM-3342: Add license-maven-plugin configuration, and describe how …
URL: https://github.com/apache/storm/pull/2959
 
 
   …to use it
   
   https://jira.apache.org/jira/browse/STORM-3342
   
   The plugin is set to fail if a dependency is added without a license. The error message is very readable, e.g. 
   ```
   [WARNING] There is 1 dependency with no license :
   [WARNING]  - org.apache.zookeeper--zookeeper--3.4.8
   ```
   
   It also warns if licenses are listed in THIRD-PARTY.properties, but not used in the build:
   
   ```
   [WARNING] dependency [org.restlet.jee--org.restlet.ext.servlet--2.3.0] does not exist in project, remove it from the missing file.
   ```
   
   While the plugin supports banning specific licenses, I think we should do the check manually. License names aren't guaranteed to be uniform across different dependencies (e.g. it might be "GPL" in one dependency and "GPLv3" in another), so I think checking manually when we vote on releases is probably necessary either way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services