You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/09 01:48:29 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #23969: Support SqlTypes Date and Timestamp (MicrosInstant) in AvroUtils

Abacn commented on code in PR #23969:
URL: https://github.com/apache/beam/pull/23969#discussion_r1017318815


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java:
##########
@@ -887,8 +925,6 @@ private static org.apache.avro.Schema getFieldSchema(
         break;
 
       case DATETIME:
-        // TODO: There is a desire to move Beam schema DATETIME to a micros representation. When

Review Comment:
   The new logical type is added (MicrosInstant) but the old field type is yet removed (DATETIME). The latter was attempt in #11456 but there was concern of breaking change. The removal of joda.time (DATETIME's input type) is aimed for Beam 3.0: #19215
   
   Will add this back and link to #19215



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org