Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]

["mhlakhani (via GitHub)" <gi...@apache.org>]

mhlakhani commented on code in PR #3402:
URL: https://github.com/apache/thrift/pull/3402#discussion_r3098135224


##########
lib/netstd/README.md:
##########
@@ -53,3 +53,64 @@ Because of the different environment requirements, migration from C# takes sligh
 - In case you are using Thrift server event handlers: the `SetEventHandler` method now starts with an uppercase letter
 - and you will also have to revise the method names of all `TServerEventHandler` descendants you have in your code
 
+# Fuzzing
+
+We use [SharpFuzz](https://github.com/Metalnem/sharpfuzz) (and its libfuzzer variant) to fuzz the Thrift protocol parsers. This is **not** integrated with oss-fuzz, so all fuzzing must be run locally. **Supported platform: Linux only.** The fuzzers are opt-in and are **not** built by `make check`; run `make build-fuzzers` (or `./buildfuzzers.sh`) explicitly.

Review Comment:
   lowpri: is it possible to have a mode where they are built by make check (without fuzz instrumentation)?
   
   the reason I ask is e.g. to avoid cases where we make some change to the code that breaks the fuzzer build, and then we don't realize it because compilation doesn't run in CI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org