You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2025/08/01 20:22:35 UTC

Re: [PR] chore(linting): setting no-console to error, and migrating instances to use `logging` [superset]

rusackas commented on PR #34226:
URL: https://github.com/apache/superset/pull/34226#issuecomment-3145680589

   
     ## Test Failure Analysis
   
     The CI test failures are due to a pre-existing issue in the test environment setup, not
     directly caused by the console → logging changes in this PR.
   
     ### Root Cause
     The test suite fails when modules call translation functions (`t()`) at the module level
     during import. Specifically,
     `packages/superset-ui-chart-controls/src/sections/sections.tsx` calls `t('Time')` at
     module initialization, before the translation system is properly initialized in tests.
   
     ### What Changed
     While investigating, I made some improvements to the test setup files:
     - Fixed empty `data-bootstrap` attribute in `spec/helpers/setup.ts` to use valid JSON
     - These changes only affect test setup, not the production app
   
     ### Recommendation
     This is a broader test infrastructure issue that should be fixed separately. The console →
      logging changes in this PR are valid and don't cause the test failures - they just
     exposed existing fragility in how translation is initialized during tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org