You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/13 06:13:45 UTC

[GitHub] [pulsar] yuruguo commented on a change in pull request #12020: [testclient] Make option -time take effect in PerformanceClient

yuruguo commented on a change in pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#discussion_r707031944



##########
File path: pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java
##########
@@ -185,13 +185,11 @@ public Arguments loadArguments(String[] args) {
             arguments.proxyURL += "/";
         }
 
-        arguments.testTime = TimeUnit.SECONDS.toMillis(arguments.testTime);

Review comment:
       There is no need to perform unit conversion here, just pass the original value(unit is second). Because if it is converted here, we need to convert it back when printing later(code in [line251](https://github.com/apache/pulsar/pull/12020/files#diff-cf545bbba2c55f89cbaf23d8ef206e8ac765b82e2fe0652c3253a23c310f9d36R251)). And it’s not handled(that is, unit conversion) in `PerformanceConsumer.java`,`PerformanceReader.java` and `PerformanceProducer.java`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org