[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1076: MINIFICPP-1373 - Add integration tests for ConsumeKafka and test cleanup issues

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1076:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1076#discussion_r657063107



##########
File path: docker/test/integration/minifi/validators/SingleOrMoreFileOutputValidator.py
##########
@@ -0,0 +1,22 @@
+import logging
+import os
+
+from .FileOutputValidator import FileOutputValidator
+
+
+class SingleOrMoreFileOutputValidator(FileOutputValidator):
+    """
+    Validates the content of a single file in the given directory.
+    """

Review comment:
       SingleOrMulti or OneOrMore (my preference) would be better naming. Also, the comment doesn't mention the possibility of multiple matches.

##########
File path: docker/test/integration/minifi/validators/NoContentCheckFileNumberValidator.py
##########
@@ -0,0 +1,25 @@
+import logging
+import os
+
+from .FileOutputValidator import FileOutputValidator
+
+
+class NoContentCheckFileNumberValidator(FileOutputValidator):
+    """
+    Validates the content of a single file in the given directory.
+    """
+

Review comment:
       This comment disagrees with the code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org