[jira] [Comment Edited] (MESOS-6790) Wrong task started time in webui

["Tomasz Janiszewski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747840#comment-15747840 ] 

Tomasz Janiszewski edited comment on MESOS-6790 at 12/14/16 9:50 AM:
---------------------------------------------------------------------

I think the right solution is to change condition in {{[void Master::updateTask(Task* task, const StatusUpdate& update)|https://github.com/apache/mesos/blob/1.1.0/src/master/master.cpp#L7628-L7633]}} that checks if new status has same state to check if new status has same state, reason and health and only if all this fields are the same drop previous message.


was (Author: janisz):
I think the right sollution is to cahgne condition in {{[void Master::updateTask(Task* task, const StatusUpdate& update)|https://github.com/apache/mesos/blob/1.1.0/src/master/master.cpp#L7628-L7633]}} that checks if new status has same state to check if new status has same state, reason and health and only if all this fields are the same drop previous message.

> Wrong task started time in webui
> --------------------------------
>
>                 Key: MESOS-6790
>                 URL: https://issues.apache.org/jira/browse/MESOS-6790
>             Project: Mesos
>          Issue Type: Bug
>          Components: webui
>            Reporter: haosdent
>              Labels: health-check, webui
>
> Reported by [~janisz]
> {quote}
> Hi
> When task has enabled Mesos healthcheck start time in UI can show wrong
> time. This happens because UI assumes that first status is task started
> [0]. This is not always true because Mesos keeps only recent tasks statuses
> [1] so when healthcheck updates tasks status it can override task start
> time displayed in webui.
> Best
> Tomek
> [0]
> https://github.com/apache/mesos/blob/master/src/webui/master/static/js/controllers.js#L140
> [1]
> https://github.com/apache/mesos/blob/f2adc8a95afda943f6a10e771aad64300da19047/src/common/protobuf_utils.cpp#L263-L265
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)