[jira] [Commented] (SOLR-16732) Misc SonarQube findings

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-16732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707980#comment-17707980 ] 

ASF subversion and git services commented on SOLR-16732:
--------------------------------------------------------

Commit 26e81ab3696ea2b44f833ac605b1072401985d11 in solr's branch refs/heads/main from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=26e81ab3696 ]

SOLR-16732: misc sonar fixes (#1525)

* Replace String non regex replaceAll with replace
* indexOf to contains or single character indexOf
* Remove NBSP in log message
* unindented if statements missing {}
* Use && instead of & for boolean comparisons
* Replace .equals with isEmpty

> Misc SonarQube findings
> -----------------------
>
>                 Key: SOLR-16732
>                 URL: https://issues.apache.org/jira/browse/SOLR-16732
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> I have been running SonarQube against the Solr project and there are some low hanging fruit things that can be addressed
> * String non regex replaceAll with replace
> * indexOf -> contains
> * NBSP in log
> * unindented if statements missing {}
> * Use && instead of & for boolean comparisons
> * Replace "".equals with isEmpty



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org