You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/12 20:53:46 UTC

[GitHub] [arrow] kou commented on pull request #7939: ARROW-9698: [C++] Remove -DNDEBUG flag leak in .pc file

kou commented on pull request #7939:
URL: https://github.com/apache/arrow/pull/7939#issuecomment-673105431


   I suggested the renaming approach because using release build libarrow.so without `NDEBUG` increases needless (empty) `CheckXXX()` function calls.
   If it's acceptable, just removing `NDEBUG` is OK to me.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org