You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/04 22:07:25 UTC
[GitHub] [commons-dbcp] fgdrf opened a new pull request #38: [DBCP-562]
avoids exposing password via JMX
fgdrf opened a new pull request #38: [DBCP-562] avoids exposing password via JMX
URL: https://github.com/apache/commons-dbcp/pull/38
for see details see https://issues.apache.org/jira/browse/DBCP-562
Signed-off-by: Frank Gasdorf <fg...@users.sourceforge.net>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-dbcp] fgdrf commented on a change in pull request #38:
[DBCP-562] avoids exposing password via JMX
Posted by GitBox <gi...@apache.org>.
fgdrf commented on a change in pull request #38: [DBCP-562] avoids exposing password via JMX
URL: https://github.com/apache/commons-dbcp/pull/38#discussion_r387979387
##########
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java
##########
@@ -201,13 +201,6 @@ default String getDefaultSchema() {
*/
int getNumIdle();
- /**
Review comment:
@garydgregory Thanks for your fast feedback, I'll investigate if its possible to "filter" by attribute while register MBean. Since the method was public its exported. Any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-dbcp] garydgregory commented on issue #38: [DBCP-562]
avoids exposing password via JMX
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #38: [DBCP-562] avoids exposing password via JMX
URL: https://github.com/apache/commons-dbcp/pull/38#issuecomment-594991633
Well, since we cannot get rid of the method within a major release, we need to workaround that by perhaps making it return always null but only when publishing an implementation as a JMX object, which might mean creating a wrapper class that delegates all methods except getPassword().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-dbcp] garydgregory commented on a change in pull request
#38: [DBCP-562] avoids exposing password via JMX
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #38: [DBCP-562] avoids exposing password via JMX
URL: https://github.com/apache/commons-dbcp/pull/38#discussion_r387964778
##########
File path: src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java
##########
@@ -201,13 +201,6 @@ default String getDefaultSchema() {
*/
int getNumIdle();
- /**
Review comment:
-1: You cannot break binary compatibility, as I mentioned on the mailing list already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services