You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by gi...@git.apache.org on 2017/06/01 22:22:22 UTC

[GitHub] keith-turner commented on a change in pull request #863: fixes - #833

keith-turner commented on a change in pull request #863: fixes - #833
URL: https://github.com/apache/incubator-fluo/pull/863#discussion_r119742932
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/observer/v1/ObserverStoreV1.java
 ##########
 @@ -209,7 +212,7 @@ public Observers getObservers(Environment env) {
       }
 
       @Override
-      public Set<Column> getObservedColumns(NotificationType nt) {
+      public ImmutableSet<Column> getObservedColumns(NotificationType nt) {
 
 Review comment:
   Personally I would leave this type as `Set` and use `ImmutableSet` internally as the implementation.  However I can see that its useful to advertise that its immutable.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services