You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/07 02:43:38 UTC
[GitHub] [spark] beliefer opened a new pull request #29382: [WIP][SPARK-32540][SQL] Eliminate filter clause test
beliefer opened a new pull request #29382:
URL: https://github.com/apache/spark/pull/29382
### What changes were proposed in this pull request?
Spark SQL supported filter clause in aggregate, for example:
select sum(distinct id) filter (where sex = 'man') from student;
But sometimes we can eliminate the filter clause in aggregate.
`SELECT COUNT(DISTINCT 1) FILTER (WHERE true) FROM testData;`
could be transformed to
`SELECT COUNT(DISTINCT 1) FROM testData;`
`SELECT COUNT(DISTINCT 1) FILTER (WHERE false) FROM testData;`
could be transformed to
`SELECT 0 FROM testData;`
### Why are the changes needed?
Optimize the filter clause in aggregation
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
New test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29382: [WIP][SPARK-32540][SQL] Eliminate filter clause test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29382:
URL: https://github.com/apache/spark/pull/29382#issuecomment-670291773
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29382: [WIP][SPARK-32540][SQL] Eliminate filter clause test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29382:
URL: https://github.com/apache/spark/pull/29382#issuecomment-670365331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer closed pull request #29382: [WIP][SPARK-32540][SQL] Eliminate filter clause test
Posted by GitBox <gi...@apache.org>.
beliefer closed pull request #29382:
URL: https://github.com/apache/spark/pull/29382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29382: [WIP][SPARK-32540][SQL] Eliminate filter clause test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29382:
URL: https://github.com/apache/spark/pull/29382#issuecomment-670291428
**[Test build #127167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127167/testReport)** for PR 29382 at commit [`8e1d685`](https://github.com/apache/spark/commit/8e1d685981e1e625958db79d0ccab72fb8c2ae0f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29382: [WIP][SPARK-32540][SQL] Eliminate filter clause test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29382:
URL: https://github.com/apache/spark/pull/29382#issuecomment-670291773
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29382: [WIP][SPARK-32540][SQL] Eliminate filter clause test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29382:
URL: https://github.com/apache/spark/pull/29382#issuecomment-670291428
**[Test build #127167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127167/testReport)** for PR 29382 at commit [`8e1d685`](https://github.com/apache/spark/commit/8e1d685981e1e625958db79d0ccab72fb8c2ae0f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29382: [WIP][SPARK-32540][SQL] Eliminate filter clause test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29382:
URL: https://github.com/apache/spark/pull/29382#issuecomment-670365331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org