You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/09/29 11:24:13 UTC

zeppelin git commit: [ZEPPELIN-2962] Fix CI fail on selenium test profile

Repository: zeppelin
Updated Branches:
  refs/heads/master 17fb97bf3 -> 12d1bb9a0


[ZEPPELIN-2962] Fix CI fail on selenium test profile

### What is this PR for?
CI is failing on selenium test profile.
This hot fix tries to fix it.

### What type of PR is it?
Hot Fix

### Todos
* [x] - Fix selenium test

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2962

### How should this be tested?
CI becomes green

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <mo...@apache.org>

Closes #2603 from Leemoonsoo/make_ci_green and squashes the following commits:

3d818c3 [Lee moon soo] comment issue number
6f9326a [Lee moon soo] comment out extensions
63f1157 [Lee moon soo] make pip quiet


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/12d1bb9a
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/12d1bb9a
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/12d1bb9a

Branch: refs/heads/master
Commit: 12d1bb9a0dc50ef31f07892de32805dec3b40c50
Parents: 17fb97b
Author: Lee moon soo <mo...@apache.org>
Authored: Fri Sep 29 02:34:40 2017 -0700
Committer: Lee moon soo <mo...@apache.org>
Committed: Fri Sep 29 04:23:41 2017 -0700

----------------------------------------------------------------------
 testing/install_external_dependencies.sh                        | 2 +-
 .../src/test/java/org/apache/zeppelin/WebDriverManager.java     | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/12d1bb9a/testing/install_external_dependencies.sh
----------------------------------------------------------------------
diff --git a/testing/install_external_dependencies.sh b/testing/install_external_dependencies.sh
index c5c0676..dc1b986 100755
--- a/testing/install_external_dependencies.sh
+++ b/testing/install_external_dependencies.sh
@@ -45,5 +45,5 @@ if [[ -n "$PYTHON" ]] ; then
   conda info -a
   conda config --add channels conda-forge
   conda install -q matplotlib pandasql ipython jupyter_client ipykernel matplotlib bokeh
-  pip install grpcio ggplot
+  pip install -q grpcio ggplot
 fi

http://git-wip-us.apache.org/repos/asf/zeppelin/blob/12d1bb9a/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java b/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
index 1405cb2..82dc9cc 100644
--- a/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
+++ b/zeppelin-server/src/test/java/org/apache/zeppelin/WebDriverManager.java
@@ -81,8 +81,9 @@ public class WebDriverManager {
         profile.setPreference("browser.helperApps.neverAsk.saveToDisk", "application/x-ustar,application/octet-stream,application/zip,text/csv,text/plain");
         profile.setPreference("network.proxy.type", 0);
 
-        profile.addExtension(new File(firebugPath));
-        profile.addExtension(new File(firepathPath));
+        // Commenting out installing extensions. See ZEPPELIN-2962.
+        // profile.addExtension(new File(firebugPath));
+        // profile.addExtension(new File(firepathPath));
 
         driver = new FirefoxDriver(ffox, profile);
       } catch (Exception e) {