You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/03 16:05:14 UTC
[GitHub] [kafka] viktorsomogyi opened a new pull request, #13069: MINOR: Check process role and set correct logdirs
viktorsomogyi opened a new pull request, #13069:
URL: https://github.com/apache/kafka/pull/13069
Currently a controller role will fail if no log.dirs are specified. This is caused by KafkaRaftServer as it merges the configs in log.dirs and metadata.log.dir. If the paths in log.dirs weren't initialized with storage-tool when the process fails. This is unwanted as controller only roles don't need log.dirs.
This fix attempts to fix that by not merging the two configs, only if the process has both broker and controller roles.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13069: MINOR: Check process role and set correct logdirs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13069:
URL: https://github.com/apache/kafka/pull/13069#issuecomment-1601966234
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] viktorsomogyi commented on pull request #13069: MINOR: Check process role and set correct logdirs
Posted by GitBox <gi...@apache.org>.
viktorsomogyi commented on PR #13069:
URL: https://github.com/apache/kafka/pull/13069#issuecomment-1369947044
@rondagostino would you please help understanding why does the controller need the log.dirs config? Does it store any data in log.dirs? As per my understanding it only needs metadata.log.dir as long as it runs in controller role only but I'm fairly new with the internal changes of KIP-500 so I might be missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] viktorsomogyi commented on pull request #13069: MINOR: Check process role and set correct logdirs
Posted by GitBox <gi...@apache.org>.
viktorsomogyi commented on PR #13069:
URL: https://github.com/apache/kafka/pull/13069#issuecomment-1369948285
(Also the PR will need test changes at least but I wanted to start some conversation early on.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] viktorsomogyi closed pull request #13069: MINOR: Check process role and set correct logdirs
Posted by "viktorsomogyi (via GitHub)" <gi...@apache.org>.
viktorsomogyi closed pull request #13069: MINOR: Check process role and set correct logdirs
URL: https://github.com/apache/kafka/pull/13069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org