You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/27 11:33:19 UTC

[GitHub] [flink] zhuzhurk commented on a diff in pull request #20057: [FLINK-28213][runtime] StreamExecutionEnvironment configure method support override pipeline.jars option

zhuzhurk commented on code in PR #20057:
URL: https://github.com/apache/flink/pull/20057#discussion_r907281806


##########
flink-core/src/main/java/org/apache/flink/configuration/ConfigUtils.java:
##########
@@ -155,5 +155,23 @@ public static Set<ConfigOption<?>> getAllConfigOptions(Class<?> configOptionsCla
         return options;
     }
 
+    /**
+     * Merge pipeline jars from current {@link Configuration} and other into configuration.
+     *
+     * @param jars the jars to be merged to configuration
+     * @param configuration the configuration object to get the pipeline.jars and merge the jars to
+     *     it
+     */
+    public static void mergePipelineJarsToConfig(Set<String> jars, Configuration configuration) {

Review Comment:
   Can we abstract it to a common method like `mergeCollectionsToConfig(Set<T> jars, Configuration configuration, final FunctionWithException<T, T, E> mapper)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org