[GitHub] [nifi] gresockj commented on pull request #5494: NIFI-9343: Adding config verification to GCP processors

[GitBox <gi...@apache.org>]

gresockj commented on pull request #5494:
URL: https://github.com/apache/nifi/pull/5494#issuecomment-990909849


   > I made a lot of tests and it's working as I'd expect this to be. A few suggestions:
   > 
   > * PutGCS, DeleteGCS - if the bucket does not exist, no error, could be something to check?
   > * PublishGCPubSub, PublishGCPubSubLite - we don't check if the topic exist, not sure if easy to check
   > * ConsumeGCPubSub, ConsumeGCPubSubLite - we don't check if the subscription exist, not sure if easy to check
   > * PutBigQueryBatch, PutBigQueryStreaming - we don't check if the dataset / table name exist, not sure if easy to check
   > 
   > Not sure if the above can be added and can definitely be follow-up JIRAs. Thoughts? (regardless of the above, I'm a +1 and I can merge, let me know)
   
   Thanks for the feedback, @pvillard31 !  I had considered these cases originally, but could not find a way to exercise these methods without making the actual calls.  However, upon further review I now see an API method named `testIamPermissions` that looks promising.  I'll check this out and add some more verification if possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org