You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/27 08:46:13 UTC

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar

liubao68 opened a new pull request #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar
URL: https://github.com/apache/servicecomb-java-chassis/pull/1672
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] WillemJiang commented on issue #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on issue #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar
URL: https://github.com/apache/servicecomb-java-chassis/pull/1672#issuecomment-604891257
 
 
   Is there any reason to remove this profile?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar
URL: https://github.com/apache/servicecomb-java-chassis/pull/1672
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar
URL: https://github.com/apache/servicecomb-java-chassis/pull/1672#issuecomment-604901409
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29656680/badge)](https://coveralls.io/builds/29656680)
   
   Coverage decreased (-0.003%) to 84.998% when pulling **bf4c354ccf058f2c9eb378030a400bcadbd93098 on liubao68:master** into **9436f0afd1d0024eef674f4d8c380ffaae7ed6f2 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar

Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1672: [SCB-1837]revert changes for SCB-1643, do not include huaweicloud jar
URL: https://github.com/apache/servicecomb-java-chassis/pull/1672#issuecomment-604893609
 
 
   > Is there any reason to remove this profile?
   
   1. some users may get compile error when they can not access huaweicloudsdk
   2. this dependency is optional, users can add manually. 
   3. foundation-auth dependent on java-chassis,  we can't guess a future workable version.  And will cause trouble to users.
   3. I added this for easy of use before,  compared to the problems mentioned above, and deside to remove it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services