[GitHub] [druid] LakshSingla commented on a diff in pull request #14198: Add wait for worker shutdown to MSQ task cancel

["LakshSingla (via GitHub)" <gi...@apache.org>]

LakshSingla commented on code in PR #14198:
URL: https://github.com/apache/druid/pull/14198#discussion_r1185857259


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTaskLauncher.java:
##########
@@ -202,12 +202,7 @@ public void stop(final boolean interrupt)
     }
 
     // Block until stopped.
-    try {
-      FutureUtils.getUnchecked(stopFuture, false);
-    }
-    catch (Throwable ignored) {
-      // Suppress.
-    }
+    waitForWorkerShutdown();

Review Comment:
   This refactoring can be applied to many places in this file as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org