[jira] [Commented] (PARQUET-1719) Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543920#comment-17543920 ] 

ASF GitHub Bot commented on PARQUET-1719:
-----------------------------------------

dssysolyatin commented on code in PR #707:
URL: https://github.com/apache/parquet-mr/pull/707#discussion_r884773399


##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java:
##########
@@ -115,9 +115,9 @@ private ParquetReader(Configuration conf,
         readSupport);
   }
 
-  private ParquetReader(List<InputFile> files,
-                        ParquetReadOptions options,
-                        ReadSupport<T> readSupport) throws IOException {
+  public ParquetReader(List<InputFile> files,

Review Comment:
   Done





> Make ParquetReader(List<InputFile>, ParquetReadOptions, ReadSupport<T>) constructor public
> ------------------------------------------------------------------------------------------
>
>                 Key: PARQUET-1719
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1719
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>            Reporter: Dmitry Sysolyatin
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>
> My application uses s3 storage to store parquet files. The problem is that there is not ability to get rid from `new Configuration(true);` which load configuration from files: 
> `core-default.xml` and `core-site.xml` every time when ParquetReader instance is created.
> I suggest just make ParquetReader(List<InputFile>, ParquetReadOptions, ReadSupport<T>) constructor public then there will be ability to do custom builder.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)