You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/09 09:35:22 UTC
[GitHub] [airflow] mik-laj opened a new pull request #10257: Improve "Before you begin" section in google-cloud-secret-manager-backend.rst
mik-laj opened a new pull request #10257:
URL: https://github.com/apache/airflow/pull/10257
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10257: Improve "Before you begin" section in google-cloud-secret-manager-backend.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10257:
URL: https://github.com/apache/airflow/pull/10257#discussion_r467560711
##########
File path: docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst
##########
@@ -26,7 +26,15 @@ a secret backend and how to manage secrets.
Before you begin
""""""""""""""""
-`Configure Secret Manager and your local environment <https://cloud.google.com/secret-manager/docs/configuring-secret-manager>`__, once per project.
+Before you start, make sure you have performed the following tasks:
+
+1. Include sendgrid subpackage as part of your Airflow installation
+
+ .. code-block:: bash
+
+ pip install airflow[google]
Review comment:
It should be
```
airflow`[sengrid]`
```
but pre-commit is sad.
> ```
> rst ``code`` is two backticks.....................................................................................................Failed
> - hook id: rst-backticks
> - exit code: 1
>
> docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst:35: pip install `airflow[google]`
>
> ```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10257: Improve guide about Google Cloud Secret Manager Backend
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10257:
URL: https://github.com/apache/airflow/pull/10257#discussion_r467563372
##########
File path: docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst
##########
@@ -26,7 +26,15 @@ a secret backend and how to manage secrets.
Before you begin
""""""""""""""""
-`Configure Secret Manager and your local environment <https://cloud.google.com/secret-manager/docs/configuring-secret-manager>`__, once per project.
+Before you start, make sure you have performed the following tasks:
+
+1. Include sendgrid subpackage as part of your Airflow installation
+
+ .. code-block:: bash
+
+ pip install airflow[google]
Review comment:
```suggestion
pip install apaache-airflow[google]
```
##########
File path: docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst
##########
@@ -26,7 +26,15 @@ a secret backend and how to manage secrets.
Before you begin
""""""""""""""""
-`Configure Secret Manager and your local environment <https://cloud.google.com/secret-manager/docs/configuring-secret-manager>`__, once per project.
+Before you start, make sure you have performed the following tasks:
+
+1. Include sendgrid subpackage as part of your Airflow installation
+
+ .. code-block:: bash
+
+ pip install airflow[google]
Review comment:
```suggestion
pip install apache-airflow[google]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #10257: Improve "Before you begin" section in google-cloud-secret-manager-backend.rst
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10257:
URL: https://github.com/apache/airflow/pull/10257#discussion_r467560786
##########
File path: docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst
##########
@@ -26,7 +26,15 @@ a secret backend and how to manage secrets.
Before you begin
""""""""""""""""
-`Configure Secret Manager and your local environment <https://cloud.google.com/secret-manager/docs/configuring-secret-manager>`__, once per project.
+Before you start, make sure you have performed the following tasks:
+
+1. Include sendgrid subpackage as part of your Airflow installation
+
+ .. code-block:: bash
+
+ pip install airflow[google]
Review comment:
```suggestion
pip install 'apache-airflow[google]'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #10257: Improve guide about Google Cloud Secret Manager Backend
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10257:
URL: https://github.com/apache/airflow/pull/10257#discussion_r467563553
##########
File path: docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst
##########
@@ -26,7 +26,15 @@ a secret backend and how to manage secrets.
Before you begin
""""""""""""""""
-`Configure Secret Manager and your local environment <https://cloud.google.com/secret-manager/docs/configuring-secret-manager>`__, once per project.
+Before you start, make sure you have performed the following tasks:
+
+1. Include sendgrid subpackage as part of your Airflow installation
+
+ .. code-block:: bash
+
+ pip install airflow[google]
Review comment:
I can't add `because pre-commit has a problem with this, but I updated the package name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10257: Improve guide about Google Cloud Secret Manager Backend
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10257:
URL: https://github.com/apache/airflow/pull/10257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org