[GitHub] [incubator-pinot] npawar commented on issue #4233: Remove depependency on Kafka stream implementation classes from pinot-core and pinot-controller tests

[GitBox <gi...@apache.org>]

npawar commented on issue #4233: Remove depependency on Kafka stream implementation classes from pinot-core and pinot-controller tests
URL: https://github.com/apache/incubator-pinot/pull/4233#issuecomment-495443116
 
 
   > Can we try not to hard-code the number of partitions to 2?? Each test should be able to start with as many partitions as needed? I do run the tests with different number of partitions on my desktop to test sometimes.
   
   Fixed. The numPartitions can now be provided via the StreamConfig property. The StreamConfig can be created using `StreamConfig streamConfig = FakeStreamConfigUtils::getDefaultLowLevelStreamConfig(int num partitions)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org