You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/03/25 21:52:32 UTC
[PR] Follow up to #17975: remove redundant Prometheus dependency entries [pinot]
xiangfu0 opened a new pull request, #17978:
URL: https://github.com/apache/pinot/pull/17978
## Summary
- follow up to #17975, which merged before the reviewer-requested cleanup landed
- remove the explicit `prometheus-metrics-config` and `prometheus-metrics-model` dependency management entries from the root `pom.xml`
- keep only `prometheus-metrics-core`, which still resolves `prometheus-metrics-config:1.5.1` transitively for the Prometheus test path
## How to reproduce
1. Start from `master` after #17975.
2. Inspect the Prometheus dependency management block in the root `pom.xml` and note that `prometheus-metrics-config` and `prometheus-metrics-model` are both managed explicitly.
3. Run:
`./mvnw -pl pinot-common -DskipTests dependency:tree -Dincludes=io.prometheus:prometheus-metrics-exporter-httpserver,io.prometheus:prometheus-metrics-core,io.prometheus:prometheus-metrics-config,io.prometheus:prometheus-metrics-model,io.prometheus.jmx:collector -Dscope=test`
4. Observe that `prometheus-metrics-config` is already brought in through `prometheus-metrics-core`, so the extra explicit entry is redundant. With this PR applied, the targeted Prometheus tests still pass even though `prometheus-metrics-model` falls back to the collector's transitive version.
## Test plan
- [x] `./mvnw -pl pinot-common -am -Dtest=YammerBrokerPrometheusMetricsTest,YammerControllerPrometheusMetricsTest,YammerServerPrometheusMetricsTest,YammerMinionPrometheusMetricsTest,DropwizardBrokerPrometheusMetricsTest,DropwizardControllerPrometheusMetricsTest,DropwizardServerPrometheusMetricsTest,DropwizardMinionPrometheusMetricsTest -Dsurefire.failIfNoSpecifiedTests=false test`
- [x] `./mvnw -pl pinot-common -DskipTests dependency:tree -Dincludes=io.prometheus:prometheus-metrics-exporter-httpserver,io.prometheus:prometheus-metrics-core,io.prometheus:prometheus-metrics-config,io.prometheus:prometheus-metrics-model,io.prometheus.jmx:collector -Dscope=test`
- [x] `./mvnw spotless:apply -pl .`
- [x] `./mvnw checkstyle:check -pl .`
- [x] `./mvnw license:format -pl .`
- [x] `./mvnw license:check -pl .`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Follow up to #17975: remove redundant Prometheus dependency entries [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17978:
URL: https://github.com/apache/pinot/pull/17978#issuecomment-4130288011
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/17978?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.51%. Comparing base ([`56faa36`](https://app.codecov.io/gh/apache/pinot/commit/56faa363989fe4f88eed47f255a335fe586f98aa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d8045f9`](https://app.codecov.io/gh/apache/pinot/commit/d8045f9544c58f05ea4b9d8e0e7177fee4a3630b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (56faa36) and HEAD (d8045f9). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (56faa36) | HEAD (d8045f9) |
>|------|------|------|
>|java-21|5|1|
>|unittests|3|1|
>|temurin|9|1|
>|unittests2|2|0|
>|java-11|4|0|
>|integration|6|0|
>|integration2|2|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17978 +/- ##
============================================
- Coverage 63.27% 55.51% -7.76%
+ Complexity 1541 745 -796
============================================
Files 3196 2498 -698
Lines 193744 142671 -51073
Branches 29807 22870 -6937
============================================
- Hits 122589 79204 -43385
+ Misses 61511 56728 -4783
+ Partials 9644 6739 -2905
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.51% <ø> (-7.76%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.51% <ø> (-7.76%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.51% <ø> (-7.76%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.51% <ø> (-0.01%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/17978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/17978?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Follow up to #17975: remove redundant Prometheus dependency entries [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #17978:
URL: https://github.com/apache/pinot/pull/17978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org