You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/04 14:02:40 UTC

[GitHub] [logging-log4j2] carterkozak opened a new pull request #507: LOG4J2-3102: AsyncAppender background thread is a daemon

carterkozak opened a new pull request #507:
URL: https://github.com/apache/logging-log4j2/pull/507


   https://issues.apache.org/jira/browse/LOG4J2-3102
   
   We didn't preserve the daemon flag in https://github.com/apache/logging-log4j2/pull/452/files#diff-6b30d73942796a35c3bcf93d46127d03cb6959fb69fb8eb84c4c6fca13bb68e6L390


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] vy commented on pull request #507: LOG4J2-3102: AsyncAppender background thread is a daemon

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #507:
URL: https://github.com/apache/logging-log4j2/pull/507#issuecomment-855764044


   Darn! Good catch @carterkozak! :clap: LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] carterkozak commented on pull request #507: LOG4J2-3102: AsyncAppender background thread is a daemon

Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #507:
URL: https://github.com/apache/logging-log4j2/pull/507#issuecomment-854982427


   rebased and committed directly. Conflict is my own fault for merging another fix with a release note!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] carterkozak closed pull request #507: LOG4J2-3102: AsyncAppender background thread is a daemon

Posted by GitBox <gi...@apache.org>.
carterkozak closed pull request #507:
URL: https://github.com/apache/logging-log4j2/pull/507


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org