You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/02 12:46:30 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue, #4081: TableReference From<&str> creates invalid table references
andygrove opened a new issue, #4081:
URL: https://github.com/apache/arrow-datafusion/issues/4081
**Describe the bug**
The logic in `impl<'a> From<&'a str> for TableReference<'a>` simply splits a string on `.` and is creating invalid table references in some cases, such as:
```
Partial { schema: "COUNT(DISTINCT partsupp", table: "ps_suppkey)" }
```
**To Reproduce**
We should write some unit tests for complex expressions
**Expected behavior**
We should add logic to determine if the string represents a column reference or a complex expression (we could use the SQL parser to parse an identifier)
**Additional context**
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #4081: TableReference From<&str> creates invalid table references
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #4081:
URL: https://github.com/apache/arrow-datafusion/issues/4081#issuecomment-1300725792
I am now wondering if this is only happening in https://github.com/apache/arrow-datafusion/pull/4050 and not in general usage so this may not be a high priority
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #4081: TableReference From<&str> creates invalid table references
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #4081:
URL: https://github.com/apache/arrow-datafusion/issues/4081#issuecomment-1300727054
It would be nice to change it to `TryFrom` though and catch cases where the string is not a column reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org