[GitHub] [superset] rusackas commented on pull request #19956: feat: Applitools Cypress workflow

[GitBox <gi...@apache.org>]

rusackas commented on PR #19956:
URL: https://github.com/apache/superset/pull/19956#issuecomment-1118743663

   > Not familiar with applitools for cypress but I have general concern how it would work with randomized css-xxx items in DOM which can be changed between builds. Would this DOM verification be stable and reliable?
   
   It doesn't even look at the dom... it literally takes screenshots of the UI and compares them to prior runs. in theory, you could change ALL SORTS of styling code, but if it looks the same, the tests will pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org