You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Dmitriy Govorukhin <dm...@gmail.com> on 2018/06/14 14:39:38 UTC

unused or only used in tests methonds

Igniters,

I found 2 methods,

1. PageStore.pageOffset(long pageId) -  it unused, seem that old artifact.
2. IgnitePageStoreManager.pagesAllocated(int grpId) - used only in test,
seem that same problem can be solved with IgnitePageStoreManager.pages(grpId,
partId).

I suggest, remove these methods for the more clear interface.

Any reason, why we can not remove them?

Re: unused or only used in tests methonds

Posted by Dmitriy Govorukhin <dm...@gmail.com>.

Igniters,

If no one objects, then I delete these methods in next refactoring task.

On Fri, Jun 15, 2018 at 6:38 PM Alexey Goncharuk <al...@gmail.com>
wrote:

> I have no objections to remove these methods.
>
> --AG
>
> чт, 14 июн. 2018 г. в 17:39, Dmitriy Govorukhin <
> dmitriy.govorukhin@gmail.com>:
>
> > Igniters,
> >
> > I found 2 methods,
> >
> > 1. PageStore.pageOffset(long pageId) -  it unused, seem that old
> artifact.
> > 2. IgnitePageStoreManager.pagesAllocated(int grpId) - used only in test,
> > seem that same problem can be solved with
> > IgnitePageStoreManager.pages(grpId,
> > partId).
> >
> > I suggest, remove these methods for the more clear interface.
> >
> > Any reason, why we can not remove them?
> >
>

Re: unused or only used in tests methonds

Posted by Alexey Goncharuk <al...@gmail.com>.

I have no objections to remove these methods.

--AG

чт, 14 июн. 2018 г. в 17:39, Dmitriy Govorukhin <
dmitriy.govorukhin@gmail.com>:

> Igniters,
>
> I found 2 methods,
>
> 1. PageStore.pageOffset(long pageId) -  it unused, seem that old artifact.
> 2. IgnitePageStoreManager.pagesAllocated(int grpId) - used only in test,
> seem that same problem can be solved with
> IgnitePageStoreManager.pages(grpId,
> partId).
>
> I suggest, remove these methods for the more clear interface.
>
> Any reason, why we can not remove them?
>