[GitHub] [incubator-echarts] wf123537200 commented on a change in pull request #13282: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537

[GitBox <gi...@apache.org>]

wf123537200 commented on a change in pull request #13282:
URL: https://github.com/apache/incubator-echarts/pull/13282#discussion_r505422595



##########
File path: src/component/tooltip/TooltipView.ts
##########
@@ -628,8 +628,9 @@ class TooltipView extends ComponentView {
             this._tooltipModel
         ]);
 
+        // fix 10537
         const tooltipTrigger = tooltipModel.get('trigger');
-        if (tooltipTrigger != null && tooltipTrigger !== 'item') {
+        if (!tooltipTrigger || tooltipTrigger === 'none') {
             return;
         }

Review comment:
       > I think this change only makes tooltip trigger on the item even if it's configured as `axis`. It will break other series and can't get the expected result of radar. In radar, the expected result is to show all the values of one indicator if tooltip.trigger is `axis`
   
   got it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org