You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/10/19 07:23:12 UTC

[PR] [Pipe] Refresh pipe user IDs when credentials change [iotdb]

Caideyipi opened a new pull request, #18914:
URL: https://github.com/apache/iotdb/pull/18914

   ## Description
   
   A pipe created from a root session receives an injected `source.user-id=0`. After `ALTER PIPE ... MODIFY SOURCE` changes its username and password to another account, the merged attributes retain that root ID. Table permission checks can consequently continue treating the pipe as root, causing `IoTDBPipePermissionIT.testSourcePermission` to transfer data before SELECT permission is granted.
   
   Resolve the user ID from explicit source and write-back sink usernames during create, replace and modify operations. Password-only modifications preserve the existing user ID. Add regression tests for replacing the injected root identity through attribute merging, explicit credentials on create/replace, and password-only updates.
   
   ## Validation
   
   - `PipeAuthenticationIdentityTest` and `ShowCreateTaskTest`: 12 tests passed on the latest master baseline.
   - Spotless, Checkstyle and `git diff --check` passed.
   - The targeted table-cluster IT was attempted locally, but the reactor JVM exhausted native memory before the test started.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added unit tests to cover the changed code paths.
   
   <hr>
   
   ##### Key changed/added classes
   
   - `TableConfigTaskVisitor`
   - `PipeAuthenticationIdentityTest`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Pipe] Refresh credential user IDs and retain privilege metadata across retries [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18914:
URL: https://github.com/apache/iotdb/pull/18914


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org