You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/05/10 06:37:16 UTC
Review Request 67053: Add inner txn handling to GraphTransaction
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67053/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-2667
https://issues.apache.org/jira/browse/ATLAS-2667
Repository: atlas
Description
-------
Some transactions need to be committed in one single shot, right now any layer that orchestrates the data persistence using different stores (e.g. AtlasEntityStore and AtlasRelationshipStore) will see two different commits. With introduction of relationships and Glossary it's become a necessity that the entity and relationships are persisted in one single transaction or else the object gets created partially and leads to an inconsistent state.
This change restricts the commit/rollback from the outermost method invocation.
Diffs
-----
repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java b3e690f96
Diff: https://reviews.apache.org/r/67053/diff/1/
Testing
-------
PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/373/console
Thanks,
Apoorv Naik
Re: Review Request 67053: Add inner txn handling to GraphTransaction
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67053/#review202827
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 10, 2018, 6:37 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67053/
> -----------------------------------------------------------
>
> (Updated May 10, 2018, 6:37 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2667
> https://issues.apache.org/jira/browse/ATLAS-2667
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Some transactions need to be committed in one single shot, right now any layer that orchestrates the data persistence using different stores (e.g. AtlasEntityStore and AtlasRelationshipStore) will see two different commits. With introduction of relationships and Glossary it's become a necessity that the entity and relationships are persisted in one single transaction or else the object gets created partially and leads to an inconsistent state.
>
> This change restricts the commit/rollback from the outermost method invocation.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java b3e690f96
>
>
> Diff: https://reviews.apache.org/r/67053/diff/1/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/373/console
>
>
> Thanks,
>
> Apoorv Naik
>
>