You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/07/30 01:51:22 UTC
Re: Review Request 36864: Style change: Space after the "..." in
variadic templates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36864/
-----------------------------------------------------------
(Updated July 29, 2015, 4:51 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Summary (updated)
-----------------
Style change: Space after the "..." in variadic templates.
Repository: mesos
Description (updated)
-------
There are a few instances of `typename...` and `typename ...` in the code base. This patch normalizes those to just `typename...` .
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 4e8c3bd1e9abf0ff24f78c8385ed9625719dcf8c
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 81f6e50baca95ad7a3a0ac1434c8db1c4de6adf2
Diff: https://reviews.apache.org/r/36864/diff/
Testing
-------
`make check`
Thanks,
Joseph Wu
Re: Review Request 36864: Style change: Space after the "..." in
variadic templates.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36864/#review93667
-----------------------------------------------------------
Ship it!
Ship It!
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp (line 50)
<https://reviews.apache.org/r/36864/#comment148078>
Accidentally removed an empty line.
- Joris Van Remoortere
On July 29, 2015, 11:51 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36864/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 11:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There are a few instances of `typename...` and `typename ...` in the code base. This patch normalizes those to just `typename...` .
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 4e8c3bd1e9abf0ff24f78c8385ed9625719dcf8c
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 81f6e50baca95ad7a3a0ac1434c8db1c4de6adf2
>
> Diff: https://reviews.apache.org/r/36864/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Joseph Wu
>
>